add warnings for deprecated ARIA attributes (#1560)

stevefaulkner · web-flow · commit e61fbeb2c81b · 2023-03-05T12:35:17.000+09:00
diff --git a/schema/.drivers/legacy.rnc b/schema/.drivers/legacy.rnc
@@ -576,6 +576,19 @@ datatypes w = "http://whattf.org/datatype-draft"
 		}
 	html.attrs &= html.attrs.version?
 
+## Obsolete ARIA attributes
+
+	aria.state.grabbed =
+		attribute aria-grabbed {
+			string
+		}
+	aria.state.dropeffect =
+		attribute aria-dropeffect {
+			string
+		}
+	aria.global &= aria.state.grabbed?
+	aria.global &= aria.state.dropeffect?
+
 ## Obsolete style attributes
 
 ## align attribute
diff --git a/schema/html5/aria.rnc b/schema/html5/aria.rnc
@@ -17,10 +17,8 @@ aria.global =
 	&	aria.prop.describedby?
 	&	aria.prop.details?
 	&	aria.state.disabled?
-	&	aria.state.dropeffect?
 	&	aria.prop.errormessage?
 	&	aria.prop.flowto?
-	&	aria.state.grabbed?
 	&	aria.prop.haspopup?
 	&	aria.state.hidden?
 	&	aria.state.invalid?
@@ -288,13 +286,6 @@ common.attrs.aria.implicit.navigation |= common.attrs.aria.implicit.landmark
 			|	string "false" #default
 			}
 
-## dropeffect
-	aria.state.dropeffect =
-		attribute aria-dropeffect
-			{	
-				list { ("copy" | "execute" | "link" | "move" | "none" | "popup") + } 
-		}
-
 ## expanded
 	aria.state.expanded =
 		attribute aria-expanded 
@@ -303,14 +294,6 @@ common.attrs.aria.implicit.navigation |= common.attrs.aria.implicit.landmark
 			|	string "undefined" #default
 			}
 
-## grabbed
-	aria.state.grabbed =
-		attribute aria-grabbed 
-			{	string "true"
-			|	string "false"
-			|	string "undefined" #default
-			}
-
 ## hidden
 	aria.state.hidden =
 		attribute aria-hidden 
diff --git a/src/nu/validator/checker/ConformingButObsoleteWarner.java b/src/nu/validator/checker/ConformingButObsoleteWarner.java
@@ -35,6 +35,16 @@ public class ConformingButObsoleteWarner extends Checker {
     public void startElement(String uri, String localName, String name,
             Attributes atts) throws SAXException {
         if ("http://www.w3.org/1999/xhtml" == uri) {
+            int len = atts.getLength();
+            for (int i = 0; i < len; i++) {
+                String attributeName = atts.getLocalName(i);
+                if ("aria-dropeffect".equals(attributeName)
+                        || "aria-grabbed".equals(attributeName)) {
+                    warn("The \u201C" + attributeName + "\u201D attribute is"
+                            + " deprecated and should not be used. Support for"
+                            + " it is poor and is unlikely to improve.");
+                        }
+            }
             if ("img" == localName) {
                 if (atts.getIndex("", "border") > -1) {
                     warn("The \u201Cborder\u201D attribute is obsolete."
diff --git a/tests b/tests
@@ -1 +1 @@
-Subproject commit a1fed6c0a73515c3e3b6266df2e0046396a94820
+Subproject commit fdf444dc0c3ac0786f8d042c4243c0dd35ab0036
