fix: add root cache existence check when returning data #7873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Aug 20, 2025
web-padawan
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
LGTM. Looks like this was fixed on main by using optional chaining in #5899.
|
This ticket/PR has been released with Vaadin 14.13.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original issue prevented grid items to be properly rendered once grid was reopened (in a dialog) and items re-set to new ones.
Bug started to appear with the introduction of 14.12.8, but the underlying issue has been there for a while it seems.
Targeting only 14.3 here, because latest branch already has same kind of check for this method.
Basically, there was a missing null / undefined check for cache.
Fixes # (issue)
#7623
Type of change
Checklist