fix: cancel request debouncer if all data has been received #7840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
commented
Aug 13, 2025
| @@ -73,7 +82,7 @@ describe('grid connector', () => { | |||
|
|
|||
| beforeEach(async () => { | |||
| // Use a smaller page size for testing | |||
| grid.pageSize = 25; | |||
| grid.pageSize = 10; | |||
There was a problem hiding this comment.
Had to adjust these tests to ensure that at least two pages fit within the viewport. Previously, this wasn't the case, and the tests passed only because the requests created by the clear method weren't cancelled rather than because the rows were actually visible.
vursen
commented
Aug 13, 2025
| @@ -92,6 +92,7 @@ public void columnTooltipOverridesGridTooltip() { | |||
| scrollToElement(grid); | |||
| // set grid tooltip | |||
| clickElementWithJs("set-grid-tooltip-button"); | |||
| flushScrolling(grid); | |||
There was a problem hiding this comment.
This test previously incorrectly passed without flushScrolling(grid) because of an extra setViewport request that wasn't cancelled.
|
sissbruecker
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that gridConnector's request debouncer is cancelled if all data has been already received from the server while the debouncer was waiting. This scenario can take place for example when calling
$connector.reset()on a non-empty grid.Extracted from #7676
Type of change