refactor!: update ConfirmDialog to not use HasOrderedComponents #7814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
744d08c to
82ba9b9
Compare
sissbruecker
approved these changes
Aug 7, 2025
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class ConfirmDialogChildrenTest { | ||
|
|
||
| private UI ui = new UI(); |
There was a problem hiding this comment.
Looks like setting up a UI is not necessary for this test suite.
There was a problem hiding this comment.
Thanks, it was a copy-paste from DialogChildrenTest file. Removed.
…rc/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
77cd2ee to
9044c5e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5276
Fixes #5275
UPD: also un-deprecated
add()andremove()methods.Type of change