Skip to content

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…7755)

* fix: prevent trying to remove already removed

Sometimes, the call to `removeCellCustomEditor` can be done to a widget
already removed from its parent, which causes a client-side error.

This change try to address that with some refactor on the custom editors
internal map.

The refactor aims to replace the keys that currently refer to the cell
address with the editor ID itself. That way, in case the same editor is
shared by more than one cell, the same `Slot` will be used. With the
current logic, more than one `Slot` element would be created for the
same editor, which could cause issues like, the editor not being shown
because it was moved to the other `Slot` parent.
@DiegoCardoso DiegoCardoso enabled auto-merge (squash) July 31, 2025 15:13
Copy link

@DiegoCardoso DiegoCardoso merged commit f3b7e64 into 24.9 Jul 31, 2025
5 checks passed
@DiegoCardoso DiegoCardoso deleted the cherry-pick-7755-to-24.9-1753974496381 branch July 31, 2025 15:39
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.9.0-alpha4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants