refactor: simplify unique key property handling #7687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
305e85d to
58a8dca
Compare
|
DiegoCardoso
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR moves the
$connector.updateUniqueItemIdPathcall fromUpdateQueue#cleartoGrid#setUniqueKeyPropertywhich is cleaner and avoids having to pass the unique key property toUpdateQueue. This change will then allow us to deprecate and removeUpdateQueueData#setUniqueKeyPropertyandUpdateQueueData#getUniqueKeyProperty.That being said, it's worth noting that the
setUniqueKeyDataGenerator(propertyName, uniqueKeyProvider)feature appears to be half broken in general as it only works correctly whenpropertyNameis"key". I've opened a corresponding issue: #7690Part of #7688
Type of change