Skip to content

refactor: remove logic associated with $connector.clearExpanded #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

refactor: remove logic associated with $connector.clearExpanded #7686

merged 3 commits into from
Jul 16, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jul 16, 2025 •
edited
Loading

Description

The $connector.clearExpanded method was introduced during the migration of TreeGrid from Vaadin Framework 8 in vaadin/vaadin-grid-flow#241. However, its current purpose is unclear, as there appears to be no scenario in which expanded items are cleared by the data communicator without also invoking $connector.collapseItems on the client.

Part of #7688

Type of change

  • Refactor

@vursen vursen marked this pull request as ready for review July 16, 2025 05:46
@vursen vursen requested review from sissbruecker, web-padawan and DiegoCardoso and removed request for web-padawan July 16, 2025 05:47
DiegoCardoso
DiegoCardoso reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what should be done with the getter and setter for hasExpandedItems in UpdateQueueData, as their only usage in the codebase is being removed in this PR.

@vursen
Copy link
Contributor Author

vursen commented Jul 16, 2025 •
edited
Loading

as their only usage in the codebase is being removed in this PR.

Good question. I was planning to deprecate and remove it in Vaadin 25 as the next step. Any concerns?

@DiegoCardoso
Copy link
Contributor

Good question. I was planning to deprecate and remove it in Vaadin 25 as the next step. Any concerns?

I think it makes sense to deprecate it, if you're not planning to use it anymore.

@vursen vursen enabled auto-merge (squash) July 16, 2025 13:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vursen vursen merged commit 4991d39 into main Jul 16, 2025
5 checks passed
@vursen vursen deleted the remove-clear-expanded-logic branch July 16, 2025 14:16
@vursen vursen mentioned this pull request Jul 17, 2025
Merged
1 task
@vursen vursen linked an issue Aug 22, 2025 that may be closed by this pull request
Deprecate legacy TreeGrid APIs #7688
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

@sissbruecker sissbruecker Awaiting requested review from sissbruecker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate legacy TreeGrid APIs
2 participants
@vursen @DiegoCardoso