refactor: deprecate Element APIs in ConfirmDialog #5495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Element API should not be exposed to component level.
|
Don't know how much these methods are used (hope not much). If somewhere else but in our own ITs, should be deprecated first 🤷♂️ |
knoobie
reviewed
Sep 22, 2023
...tegration-tests/src/main/java/com/vaadin/flow/component/confirmdialog/tests/FeaturesDiy.java
Outdated
Show resolved
Hide resolved
web-padawan
requested changes
Sep 22, 2023
…ntegration-tests/src/main/java/com/vaadin/flow/component/confirmdialog/tests/FeaturesDiy.java Co-authored-by: Knoobie <Knoobie@gmx.de>
tomivirkki
requested changes
Sep 27, 2023
...tegration-tests/src/main/java/com/vaadin/flow/component/confirmdialog/tests/FeaturesDiy.java
Outdated
Show resolved
Hide resolved
…ntegration-tests/src/main/java/com/vaadin/flow/component/confirmdialog/tests/FeaturesDiy.java Co-authored-by: Knoobie <Knoobie@gmx.de>
tomivirkki
reviewed
Oct 4, 2023
...tegration-tests/src/main/java/com/vaadin/flow/component/confirmdialog/tests/FeaturesDiy.java
Show resolved
Hide resolved
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
tomivirkki
reviewed
Oct 4, 2023
...tegration-tests/src/main/java/com/vaadin/flow/component/confirmdialog/tests/FeaturesDiy.java
Show resolved
Hide resolved
tomivirkki
approved these changes
Oct 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Oct 5, 2023
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Element API should not be exposed to the component level.
Type of change
Refactor