Skip to content

[Crud] Deprecate CrudElement.getEditor and provide alternative #7763

@sissbruecker

Description

@sissbruecker

Describe your motivation

CrudElement.getEditor currently either returns the dialog / overlay element in dialog mode, or the Crud itself in other modes.

The first scenario won't work as such anymore after moving the dialog and overlay into the shadow root.

The second scenario is misleading, as you don't get the element that contains editor-specific controls (e.g. text fields, save / cancel button), but the Crud itself. For example, if you use getEditor to retrieve the last text field, you may get a filter from the slotted grid, instead of a text field from the form.

Describe the solution you'd like

Deprecate getEditor as it has no real purpose after the overlay refactoring. Make it return the Crud itself in all cases to keep it in working shape.

Since most usage of getEditor seems to be accessing fields from the form, provide an alternative getForm that returns the slotted form. Accessing buttons in the editor is already possible through other methods.

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

v25To be done in V25

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions