fix: add router-ignore attribute to Anchor with StreamResource #7691
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @platosha)
7ade6b2 to
740a8f0
Compare
740a8f0 to
6faad98
Compare
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @platosha and @ptdatkhtn)
flow-html-components/src/main/java/com/vaadin/flow/component/html/Anchor.java, line 117 at r2 (raw file):
public void setHref(String href) { set(hrefDescriptor, href); getElement().removeAttribute(ROUTER_IGNORE_ATTRIBUTE);
Why not just set the attribute in the constructor? I dont see any advantage on setting/removing the atribute when the href is set or not
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @manolo and @ptdatkhtn)
flow-html-components/src/main/java/com/vaadin/flow/component/html/Anchor.java, line 117 at r2 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Why not just set the attribute in the constructor? I dont see any advantage on setting/removing the atribute when the href is set or not
As discussed in F2F, it’s unexpected that Anchor produces something different than <a href>
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained (waiting on @manolo and @ptdatkhtn)
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, 2 of 1 LGTMs obtained (waiting on @ptdatkhtn)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2.
Reviewable status:
Fixes #7623
This change is