Skip to content

fix: notify listener for all InputStreamDownloadCallback failures #21994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

fix: notify listener for all InputStreamDownloadCallback failures #21994

merged 1 commit into from
Aug 6, 2025

Conversation

mcollovati
Copy link
Collaborator

Makes sure that transfer progress listeners are notified also for DownloadResponse.error return value and unchecked exception thrown by InputStreamDownloadCallback.

Fixes #21931

@mcollovati
fix: notify listener for all InputStreamDownloadCallback failures
4b8cd49 
Makes sure that transfer progress listeners are notified also
for DownloadResponse.error return value and unchecked exception
thrown by InputStreamDownloadCallback.

Fixes #21931
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

Quality Gate Passed Quality Gate passed

Issues
89 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025

Test Results

1 237 files  ± 0  1 237 suites  ±0   1h 14m 57s ⏱️ + 1m 36s
8 499 tests + 2  8 439 ✅ + 2  60 💤 ±0  0 ❌ ±0 
8 905 runs  +41  8 836 ✅ +40  69 💤 +1  0 ❌ ±0 

Results for commit 4b8cd49. ± Comparison against base commit 6ced5a6.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both. 
com.vaadin.flow.server.streams.InputStreamDownloadHandlerTest ‑ transferProgressListener_addListener_callbackErrorOccured_errorlistenerInvoked
com.vaadin.flow.server.streams.InputStreamDownloadHandlerTest ‑ transferProgressListener_addListener_errorOccured_errorlistenerInvoked

com.vaadin.flow.server.streams.InputStreamDownloadHandlerTest ‑ transferProgressListener_addListener_callbackIOExceptionOccurred_errorListenerInvoked
com.vaadin.flow.server.streams.InputStreamDownloadHandlerTest ‑ transferProgressListener_addListener_callbackResponseError_errorListenerInvoked
com.vaadin.flow.server.streams.InputStreamDownloadHandlerTest ‑ transferProgressListener_addListener_callbackUncheckedExceptionOccurred_errorListenerInvoked
com.vaadin.flow.server.streams.InputStreamDownloadHandlerTest ‑ transferProgressListener_addListener_errorOccurred_errorListenerInvoked

@mshabarov mshabarov merged commit 8bfe7ab into main Aug 6, 2025
27 checks passed
@mshabarov mshabarov deleted the issues/21931-notify_listener_for_downloadresponse_error branch August 6, 2025 10:39
vaadin-bot pushed a commit that referenced this pull request Aug 6, 2025
@mcollovati @vaadin-bot
fix: notify listener for all InputStreamDownloadCallback failures (#2…
76494af 
…1994)

Makes sure that transfer progress listeners are notified also
for DownloadResponse.error return value and unchecked exception
thrown by InputStreamDownloadCallback.

Fixes #21931
vaadin-bot pushed a commit that referenced this pull request Aug 6, 2025
@mcollovati @vaadin-bot
fix: notify listener for all InputStreamDownloadCallback failures (#2…
d39b83e 
…1994)

Makes sure that transfer progress listeners are notified also
for DownloadResponse.error return value and unchecked exception
thrown by InputStreamDownloadCallback.

Fixes #21931
vaadin-bot added a commit that referenced this pull request Aug 6, 2025
@vaadin-bot @mcollovati
fix: notify listener for all InputStreamDownloadCallback failures (#2…
18f88df 
…1994) (#21996)

Makes sure that transfer progress listeners are notified also
for DownloadResponse.error return value and unchecked exception
thrown by InputStreamDownloadCallback.

Fixes #21931

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Aug 6, 2025
@vaadin-bot @mcollovati
fix: notify listener for all InputStreamDownloadCallback failures (#2…
319898f 
…1994) (#21995)

Makes sure that transfer progress listeners are notified also
for DownloadResponse.error return value and unchecked exception
thrown by InputStreamDownloadCallback.

Fixes #21931

Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.8 cherry-picked-24.9 target/24.8 target/24.9 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DownloadHandler::whenComplete not called on error
3 participants
@mcollovati @mshabarov @vaadin-bot