Skip to content

Conversation

mcollovati
Copy link
Collaborator

When pressing the login button on the splash screen, it redirects the user to the vaadin.com license validation endpoint and polls the license server to download a license key. If the license key is available the application browser page gets reloaded. Otherwise an error message is shown.

Copy link

github-actions bot commented Aug 4, 2025

Test Results

1 240 files  1 240 suites   1h 17m 0s ⏱️
8 533 tests 8 467 ✅ 66 💤 0 ❌
8 946 runs  8 871 ✅ 75 💤 0 ❌

Results for commit 2c1fc79.

♻️ This comment has been updated with latest results.

When pressing the login button on the splash screen, redirects the user
to the vaadin.com license validation endpoint and polls license server
to download a license key. If the license key is available the
application browser page gets reloaded. Otherwise an error message is
shown.
@mcollovati mcollovati force-pushed the pretrial/feat/wait-for-license-key branch from 63931bb to 440f1ef Compare August 4, 2025 06:14
@mshabarov mshabarov requested review from tltv and mshabarov August 4, 2025 11:46
@tltv tltv self-assigned this Aug 5, 2025
Copy link
Member

@tltv tltv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshabarov mshabarov marked this pull request as ready for review August 6, 2025 09:10
Copy link

sonarqubecloud bot commented Aug 6, 2025

@mshabarov mshabarov merged commit 640bd3f into feature/pre-trial Aug 6, 2025
26 of 27 checks passed
@mshabarov mshabarov deleted the pretrial/feat/wait-for-license-key branch August 6, 2025 10:27
@github-project-automation github-project-automation bot moved this from 🔎Iteration reviews to Done in Vaadin Flow ongoing work (Vaadin 10+) Aug 6, 2025
mcollovati added a commit that referenced this pull request Aug 6, 2025
)

* feat: try to download license key when log in from splash screen

When pressing the login button on the splash screen, redirects the user
to the vaadin.com license validation endpoint and polls license server
to download a license key. If the license key is available the
application browser page gets reloaded. Otherwise an error message is
shown.

* Apply suggestions from code review

---------

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mcollovati added a commit that referenced this pull request Aug 7, 2025
)

* feat: try to download license key when log in from splash screen

When pressing the login button on the splash screen, redirects the user
to the vaadin.com license validation endpoint and polls license server
to download a license key. If the license key is available the
application browser page gets reloaded. Otherwise an error message is
shown.

* Apply suggestions from code review

---------

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mcollovati added a commit that referenced this pull request Aug 7, 2025
)

* feat: try to download license key when log in from splash screen

When pressing the login button on the splash screen, redirects the user
to the vaadin.com license validation endpoint and polls license server
to download a license key. If the license key is available the
application browser page gets reloaded. Otherwise an error message is
shown.

* Apply suggestions from code review

---------

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mcollovati added a commit that referenced this pull request Aug 7, 2025
)

* feat: try to download license key when log in from splash screen

When pressing the login button on the splash screen, redirects the user
to the vaadin.com license validation endpoint and polls license server
to download a license key. If the license key is available the
application browser page gets reloaded. Otherwise an error message is
shown.

* Apply suggestions from code review

---------

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov added a commit that referenced this pull request Aug 8, 2025
)

* feat: try to download license key when log in from splash screen

When pressing the login button on the splash screen, redirects the user
to the vaadin.com license validation endpoint and polls license server
to download a license key. If the license key is available the
application browser page gets reloaded. Otherwise an error message is
shown.

* Apply suggestions from code review

---------

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov added a commit that referenced this pull request Aug 8, 2025
)

* feat: try to download license key when log in from splash screen

When pressing the login button on the splash screen, redirects the user
to the vaadin.com license validation endpoint and polls license server
to download a license key. If the license key is available the
application browser page gets reloaded. Otherwise an error message is
shown.

* Apply suggestions from code review

---------

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.9.0-alpha4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants