fix(vaadin-spring): enable client-side redirects for TypeScript login #21980
Conversation
See vaadin/hilla#3807, where the issue currently manifests. VaadinSavedRequestAwareAuthenticationSuccessHandler isn't actually saved request aware unless RequestCache is correctly shared with it in the configuration, which VaadinSecurityConfigurer was failing to do due to order of events: authentication is configured before customizing request cache. This change makes sure that VaadinDefaultRequestCache instance is set for VaadinSavedRequestAwareAuthenticationSuccessHandler during configuration.
|
|
Hi @platosha and @platosha, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually? |
|
Hi @platosha and @platosha, when i performed cherry-pick to this commit to 24.8, i have encountered the following issue. Can you take a look and pick it manually? |
…#21980) See vaadin/hilla#3807, where the issue currently manifests. VaadinSavedRequestAwareAuthenticationSuccessHandler isn't actually saved request aware unless RequestCache is correctly shared with it in the configuration, which VaadinSecurityConfigurer was failing to do due to order of events: authentication is configured before customizing request cache. This change makes sure that VaadinDefaultRequestCache instance is set for VaadinSavedRequestAwareAuthenticationSuccessHandler during configuration.
…#21980) See vaadin/hilla#3807, where the issue currently manifests. VaadinSavedRequestAwareAuthenticationSuccessHandler isn't actually saved request aware unless RequestCache is correctly shared with it in the configuration, which VaadinSecurityConfigurer was failing to do due to order of events: authentication is configured before customizing request cache. This change makes sure that VaadinDefaultRequestCache instance is set for VaadinSavedRequestAwareAuthenticationSuccessHandler during configuration.
…#21980) (#21984) See vaadin/hilla#3807, where the issue currently manifests. VaadinSavedRequestAwareAuthenticationSuccessHandler isn't actually saved request aware unless RequestCache is correctly shared with it in the configuration, which VaadinSecurityConfigurer was failing to do due to order of events: authentication is configured before customizing request cache. This change makes sure that VaadinDefaultRequestCache instance is set for VaadinSavedRequestAwareAuthenticationSuccessHandler during configuration. Co-authored-by: Anton Platonov <anton@vaadin.com>
…#21980) (#21985) See vaadin/hilla#3807, where the issue currently manifests. VaadinSavedRequestAwareAuthenticationSuccessHandler isn't actually saved request aware unless RequestCache is correctly shared with it in the configuration, which VaadinSecurityConfigurer was failing to do due to order of events: authentication is configured before customizing request cache. This change makes sure that VaadinDefaultRequestCache instance is set for VaadinSavedRequestAwareAuthenticationSuccessHandler during configuration. Co-authored-by: Anton Platonov <anton@vaadin.com>
See vaadin/hilla#3807, where the issue currently manifests.
VaadinSavedRequestAwareAuthenticationSuccessHandlerisn't actually saved request aware unlessRequestCacheis correctly shared with it in the configuration, whichVaadinSecurityConfigurerwas failing to do due to order of events: authentication is configured before customizing request cache.This change makes sure that
VaadinDefaultRequestCacheinstance is set forVaadinSavedRequestAwareAuthenticationSuccessHandlerduring configuration.