Skip to content

fix: notify listeners when InputStream download handler callback fails (#21952) (CP: 24.8) #21963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix: notify listeners when InputStream download handler callback fails (#21952) (CP: 24.8) #21963

merged 1 commit into from
Jul 28, 2025

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@mcollovati @vaadin-bot
fix: notify listeners when InputStream download handler callback fails (
8325d3f 
#21952)

When a callback provided to DownloadHandler.fromInputStream throws an IOException
the transfer progress listeners are not notified about the error.
This change catched IOException potentially thrown by the callback and notifies
the registered listeners.

Part of #21931
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) July 28, 2025 11:13
@github-actions GitHub Actions
Copy link

Test Results

1 236 files  ± 0  1 236 suites  ±0   1h 13m 33s ⏱️ - 1m 35s
8 560 tests + 2  8 504 ✅ + 2  56 💤 ±0  0 ❌ ±0 
8 952 runs   - 11  8 887 ✅  - 11  65 💤 ±0  0 ❌ ±0 

Results for commit 8325d3f. ± Comparison against base commit 65552b3.

@vaadin-bot vaadin-bot merged commit 986f240 into 24.8 Jul 28, 2025
25 of 27 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-21952-to-24.8-1753700607313 branch July 28, 2025 11:18
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.8.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Vaadin 24.8.6 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @vaadin-review-bot @mcollovati