Skip to content

Conversation

mcollovati
Copy link
Collaborator

No description provided.

@mcollovati mcollovati requested a review from tltv July 28, 2025 09:17
Copy link

github-actions bot commented Jul 28, 2025

Test Results

1 240 files  1 240 suites   1h 17m 14s ⏱️
8 526 tests 8 463 ✅ 63 💤 0 ❌
8 931 runs  8 859 ✅ 72 💤 0 ❌

Results for commit fb4e44e.

♻️ This comment has been updated with latest results.

Copy link
Member

@tltv tltv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor thing, there's still watermarked in a package name. It should probably say bannered now.

@mcollovati
Copy link
Collaborator Author

LGTM. One minor thing, there's still watermarked in a package name. It should probably say bannered now.

Good point. I'll update the package names.

@mcollovati mcollovati force-pushed the prertial/add-production-banner-to-embedded-component branch from 8f45777 to fb4e44e Compare July 28, 2025 13:49
Copy link

@mcollovati mcollovati requested a review from tltv July 28, 2025 14:06
@tltv tltv merged commit 0aee21a into feature/pre-trial Jul 29, 2025
27 checks passed
@tltv tltv deleted the prertial/add-production-banner-to-embedded-component branch July 29, 2025 08:17
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.9.0-alpha4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants