fix(spring): CSRF login response for TypeScript forms #21939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just out of curiosity: If I see it correctly, this pull request does not add any additional tests to ensure that this behavior won't break again. Does it make sense to have an integration or other test that makes sure stateless security works with CSRF? |
a32aee3 to
b1641ed
Compare
platosha
added a commit
to vaadin/hilla
that referenced
this pull request
Jul 28, 2025
…urity Connected to #3697 Depends on vaadin/flow#21939
platosha
added a commit
to vaadin/hilla
that referenced
this pull request
Jul 28, 2025
…urity Connected to #3697 Depends on vaadin/flow#21939
platosha
added a commit
to vaadin/hilla
that referenced
this pull request
Jul 28, 2025
…urity Connected to #3697 Depends on vaadin/flow#21939
Correct, however, the setup is in the Hilla repository. The issue was not caught previously due to a difference in security config between docs and test setup, see vaadin/hilla#3807 addressing this. |
|
mcollovati
approved these changes
Aug 1, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
vaadin-bot
added a commit
that referenced
this pull request
Aug 1, 2025
Fixes vaadin/hilla#3697 Co-authored-by: Anton Platonov <anton@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Aug 1, 2025
Fixes vaadin/hilla#3697 Co-authored-by: Anton Platonov <anton@vaadin.com>
platosha
added a commit
to vaadin/hilla
that referenced
this pull request
Aug 5, 2025
…urity (#3807) * test(security): verify setup with sessions disabled and stateless security Connected to #3697 Depends on vaadin/flow#21939 * test(security): assert endpoints in the same test
vaadin-bot
pushed a commit
to vaadin/hilla
that referenced
this pull request
Aug 5, 2025
…urity (#3807) * test(security): verify setup with sessions disabled and stateless security Connected to #3697 Depends on vaadin/flow#21939 * test(security): assert endpoints in the same test
vaadin-bot
pushed a commit
to vaadin/hilla
that referenced
this pull request
Aug 5, 2025
…urity (#3807) * test(security): verify setup with sessions disabled and stateless security Connected to #3697 Depends on vaadin/flow#21939 * test(security): assert endpoints in the same test
Lodin
pushed a commit
to vaadin/hilla
that referenced
this pull request
Aug 5, 2025
…urity (#3807) * test(security): verify setup with sessions disabled and stateless security Connected to #3697 Depends on vaadin/flow#21939 * test(security): assert endpoints in the same test
cromoteca
added a commit
to vaadin/hilla
that referenced
this pull request
Aug 6, 2025
…urity (#3807) (CP: 24.9) (#3834) test(security): verify setup with sessions disabled and stateless security (#3807) * test(security): verify setup with sessions disabled and stateless security Connected to #3697 Depends on vaadin/flow#21939 * test(security): assert endpoints in the same test Co-authored-by: Anton Platonov <platosha@gmail.com> Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
cromoteca
added a commit
to vaadin/hilla
that referenced
this pull request
Aug 6, 2025
…urity (#3807) (CP: 24.8) (#3835) test(security): verify setup with sessions disabled and stateless security (#3807) * test(security): verify setup with sessions disabled and stateless security Connected to #3697 Depends on vaadin/flow#21939 * test(security): assert endpoints in the same test Co-authored-by: Anton Platonov <platosha@gmail.com> Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
Lodin
pushed a commit
to vaadin/hilla
that referenced
this pull request
Aug 6, 2025
…urity (#3807) * test(security): verify setup with sessions disabled and stateless security Connected to #3697 Depends on vaadin/flow#21939 * test(security): assert endpoints in the same test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/hilla#3697