Skip to content

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Jul 23, 2025

Fixes #18318

Copy link

github-actions bot commented Jul 23, 2025

Test Results

1 237 files  ± 0  1 237 suites  ±0   1h 13m 50s ⏱️ -8s
8 488 tests ± 0  8 428 ✅  -  3  60 💤 +3  0 ❌ ±0 
8 834 runs   - 59  8 765 ✅  - 62  69 💤 +3  0 ❌ ±0 

Results for commit b715517. ± Comparison against base commit 6f361b7.

This pull request skips 3 tests.
com.vaadin.flow.server.VaadinSessionTest ‑ checkHasLock_assert
com.vaadin.flow.server.VaadinSessionTest ‑ checkHasLock_log
com.vaadin.flow.server.VaadinSessionTest ‑ checkHasLock_throw

♻️ This comment has been updated with latest results.

@tepi tepi requested a review from mcollovati July 23, 2025 13:53
Copy link

@mcollovati mcollovati changed the title chore: remove setConfiguration from VaadinSession chore!: remove setConfiguration from VaadinSession Jul 24, 2025
@mcollovati mcollovati merged commit db046b4 into main Jul 24, 2025
40 of 44 checks passed
@mcollovati mcollovati deleted the chore/remove-setconfiguration-from-vaadinsession branch July 24, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeploymentConfiguration is retained in VaadinSession over session store-load cycle
3 participants