feat: show watermark in production mode #21915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mcollovati
commented
Jul 18, 2025
flow-tests/test-watermarked-application/flow-application/pom.xml
Outdated
Show resolved
Hide resolved
flow-tests/test-watermarked-application/commercial-addon/pom.xml
Outdated
Show resolved
Hide resolved
...server/src/test/java/com/vaadin/flow/server/frontend/TaskGenerateWatermarkComponentTest.java
Outdated
Show resolved
Hide resolved
Test Results1 238 files 1 238 suites 1h 15m 46s ⏱️ Results for commit 89418a7. ♻️ This comment has been updated with latest results. |
tltv
reviewed
Jul 21, 2025
flow-server/src/main/java/com/vaadin/flow/server/frontend/BundleValidationUtil.java
Show resolved
Hide resolved
mcollovati
commented
Jul 21, 2025
flow-server/src/main/java/com/vaadin/flow/server/frontend/BundleValidationUtil.java
Outdated
Show resolved
Hide resolved
tltv
reviewed
Jul 21, 2025
...ests/test-watermarked-application/src/main/java/com/vaadin/flow/watermarked/ui/MainView.java
Outdated
Show resolved
Hide resolved
...s/test-watermarked-application/src/test/java/com/vaadin/flow/watermarked/ui/WatermarkIT.java
Outdated
Show resolved
Hide resolved
|
tltv
reviewed
Jul 21, 2025
| </style> | ||
|
|
||
| <div class='container'> | ||
| <span class='logo'>vaadin }></span> |
There was a problem hiding this comment.
How about showing actual Vaadin logo here instead of the plain text. Following svg is copied from the Vaadin home page:
<svg width="111" height="26" fill="none" xmlns="http://www.w3.org/2000/svg"> <path class="haas-logo-textmark" d="M12.32 5.518c-.852 0-1.419.401-1.797 1.276l-3.38 7.256-3.356-7.256c-.378-.875-.946-1.276-1.797-1.276-1.04 0-1.89.85-1.89 1.89 0 .331.094.662.236.922l5.129 11.014c.024.071.047.119.094.19.213.401.568.685.993.85.19.071.402.119.615.119.212 0 .425-.048.614-.119a1.76 1.76 0 0 0 .993-.85c.023-.048.047-.119.094-.19l5.106-10.99c.165-.284.26-.615.26-.945-.024-1.04-.875-1.891-1.915-1.891ZM21.584 16.697a3.632 3.632 0 0 1-3.616-3.616 3.631 3.631 0 0 1 3.616-3.616 3.631 3.631 0 0 1 3.617 3.616 3.631 3.631 0 0 1-3.617 3.616Zm7.398-3.616c0-4.113-3.332-7.469-7.445-7.469s-7.445 3.356-7.445 7.469 3.356 7.469 7.469 7.469a7.532 7.532 0 0 0 3.97-1.135l.166-.118.07.19c.26.637.852 1.063 1.537 1.063.922 0 1.655-.733 1.655-1.678V13.08h.023ZM37.562 16.697a3.631 3.631 0 0 1-3.616-3.616 3.631 3.631 0 0 1 3.616-3.616 3.631 3.631 0 0 1 3.616 3.616 3.631 3.631 0 0 1-3.616 3.616Zm7.398-3.616c0-4.113-3.333-7.469-7.445-7.469-4.113 0-7.445 3.356-7.445 7.469s3.356 7.469 7.468 7.469a7.532 7.532 0 0 0 3.971-1.135l.19-.118.07.19c.26.637.851 1.063 1.537 1.063.921 0 1.654-.733 1.654-1.678V13.08ZM53.445 16.58a3.53 3.53 0 0 1-3.522-3.523 3.53 3.53 0 0 1 3.522-3.521 3.53 3.53 0 0 1 3.522 3.521 3.53 3.53 0 0 1-3.522 3.522Zm4.136 2.859a1.72 1.72 0 0 0 1.607 1.087c.946 0 1.726-.78 1.726-1.725V1.949c0-.946-.804-1.726-1.75-1.726-.945 0-1.748.78-1.748 1.726v4.869l-.142-.119c-1.182-.732-2.458-1.11-3.829-1.11-4.112 0-7.445 3.356-7.445 7.468 0 4.113 3.356 7.47 7.469 7.47a7.594 7.594 0 0 0 3.97-1.135l.119-.071.023.118ZM81.997 8.047c-1.158-1.23-2.836-1.844-5.01-1.844-.072 0-1.797.118-2.979.78a1.93 1.93 0 0 0-1.844-1.347c-1.04 0-1.914.85-1.938 1.89v11.11c0 1.063.875 1.938 1.938 1.938a1.947 1.947 0 0 0 1.939-1.939v-5.909c0-1.229.898-2.552 2.883-2.552 1.915 0 2.765 1.37 2.765 2.34v6.145c0 1.064.875 1.938 1.939 1.938a1.947 1.947 0 0 0 1.938-1.938v-5.862c.023-.212.165-2.86-1.631-4.75ZM65.594 5.612a1.958 1.958 0 0 0-1.962 1.891v11.038c0 1.087.875 1.962 1.962 1.962a1.957 1.957 0 0 0 1.962-1.962V7.503a1.958 1.958 0 0 0-1.962-1.89ZM65.641.2c1.135 0 2.056.921 2.056 2.056a2.058 2.058 0 0 1-2.056 2.056 2.058 2.058 0 0 1-2.056-2.056c0-1.135.922-2.056 2.056-2.056Z" fill="currentColor"></path><path d="M94.5 11.497c-.07 0-.142-.023-.213-.023-.709 0-1.442-.166-1.442-1.891v-5.72c0-2.576-1.205-3.592-3.64-3.592h-2.08c-.685 0-1.252.496-1.252 1.205 0 .685.567 1.229 1.253 1.229h.709c.78 0 1.323.496 1.323 1.678v5.625c0 2.553 1.891 2.766 2.908 2.837v.047c-1.017.095-2.908.284-2.908 2.836v5.626c0 1.181-.543 1.843-1.323 1.843h-.71c-.685 0-1.252.52-1.252 1.23 0 .684.567 1.228 1.253 1.228h2.08c2.434 0 3.64-1.229 3.64-3.805v-5.744c0-1.725.732-1.89 1.441-1.89.071 0 .142 0 .213-.024a1.329 1.329 0 0 0 1.253-1.347c0-.733-.567-1.3-1.253-1.348ZM110.1 12.821c0-.614-.355-1.134-.875-1.37-.024 0-.047-.024-.071-.024l-9.667-5.224a1.685 1.685 0 0 0-2.505 1.465c0 .733.354 1.253 1.134 1.584l6.666 3.57-6.666 3.568c-.78.355-1.158.85-1.158 1.584a1.685 1.685 0 0 0 2.506 1.465l9.667-5.223c.023 0 .023-.024.047-.024.567-.213.922-.756.922-1.37Z" fill="#00B4F0"></path>
</svg>
There was a problem hiding this comment.
Excellent idea!
There was a problem hiding this comment.
I have some trouble in properly formatting the banner with the SVG.
I'll make a separate PR to fix that
mcollovati
added a commit
that referenced
this pull request
Jul 24, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mcollovati
added a commit
that referenced
this pull request
Jul 30, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mcollovati
added a commit
that referenced
this pull request
Aug 5, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mcollovati
added a commit
that referenced
this pull request
Aug 6, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mcollovati
added a commit
that referenced
this pull request
Aug 7, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mcollovati
added a commit
that referenced
this pull request
Aug 7, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mcollovati
added a commit
that referenced
this pull request
Aug 7, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mshabarov
pushed a commit
that referenced
this pull request
Aug 8, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
mshabarov
pushed a commit
that referenced
this pull request
Aug 8, 2025
Shows a watermark component at runtime for watermarked applications running in production. The watermark component is added to the bundle at build time and activated if needed at runtime.
|
This ticket/PR has been released with Vaadin 24.9.0-alpha4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows a watermark component at runtime for watermarked applications
running in production. The watermark component is added to the bundle
at build time and activated if needed at runtime