Skip to content

Drop support for Bower / WebJars / Compatibility Mode in upcoming minor release Vaadin 14.12 / Flow 2.11 #19675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 101 commits into from
Jul 23, 2024
Merged

Drop support for Bower / WebJars / Compatibility Mode in upcoming minor release Vaadin 14.12 / Flow 2.11 #19675

merged 101 commits into from
Jul 23, 2024

Conversation

AlainaFaisal
Copy link
Contributor

Description

Implementation for dropinng support for Bower / WebJars / Compatibility Mode in upcoming minor release Vaadin 14.12 / Flow 2.11

Fixes #19647

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@AlainaFaisal AlainaFaisal requested a review from mshabarov July 5, 2024 07:59
@manolo
Copy link
Member

manolo commented Jul 5, 2024

@AlainaFaisal please change the target branch of this PR to 14.12

@mshabarov
Copy link
Contributor

To be precise, to 2.11

@ZheSun88
Copy link
Contributor

ZheSun88 commented Jul 5, 2024

@AlainaFaisal
you can click edit and update the branch where the red arrow point
image

@AlainaFaisal AlainaFaisal changed the base branch from main to 2.11 July 5, 2024 08:08
@AlainaFaisal AlainaFaisal changed the title Drop support for Bower / WebJars / Compatibility Mode in upcoming minor release Vaadin 14.12 / Flow 2.11 #19647 Drop support for Bower / WebJars / Compatibility Mode in upcoming minor release Vaadin 14.12 / Flow 2.11 Jul 5, 2024
mshabarov
mshabarov previously requested changes Jul 5, 2024
View reviewed changes
@mshabarov
Copy link
Contributor

mshabarov commented Jul 5, 2024 •
edited
Loading

I found more entries in the codes that should be removed:

  • Lumo - remove html import annotations.
  • Material - same
  • FrontendDataProvider - should throw if finds html import annotation
  • ComponentMetaData - looks for html import dependecies.

Please double check all the usages of AtHtmlImport annotation in the project.

@mshabarov
Copy link
Contributor

flow-server-compatibility-mode module is not needed anymore I think.

@mshabarov
Copy link
Contributor

mshabarov commented Jul 5, 2024 •
edited
Loading

Check also WebComponentBootstrapHandler, UIInternals. They have compatibility mode checks, like

if (getSession().getConfiguration().isCompatibilityMode()) {
            updateTheme(target, path);
        }

@tepi tepi self-requested a review July 8, 2024 06:08
tepi
tepi reviewed Jul 8, 2024
View reviewed changes
tepi
tepi reviewed Jul 8, 2024
View reviewed changes
tepi
tepi reviewed Jul 8, 2024
View reviewed changes
tepi
tepi reviewed Jul 8, 2024
View reviewed changes
tepi
tepi reviewed Jul 8, 2024
View reviewed changes
AlainaFaisal and others added 21 commits July 22, 2024 11:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tepi tepi enabled auto-merge (squash) July 23, 2024 12:03
@tepi tepi dismissed mshabarov’s stale review July 23, 2024 12:04

Stale review

@tepi tepi merged commit d774ea2 into 2.11 Jul 23, 2024
@tepi tepi deleted the Drop_Bower_Support branch July 23, 2024 12:04
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 14.12.0.alpha1 and is also targeting the upcoming stable 14.12.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati left review comments

@mshabarov mshabarov mshabarov left review comments

@tepi tepi tepi approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 14.12.0 Released with Vaadin 14.12.0.alpha1 +1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Bower / WebJars / Compatibility Mode in upcoming minor release Vaadin 14.12 / Flow 2.11
7 participants
@AlainaFaisal @manolo @mshabarov @ZheSun88 @tepi @vaadin-bot @mcollovati