Skip to content

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Jan 15, 2024

Deprecates @HtmlImport and compatibility mode / bower mode

@tepi tepi requested a review from mshabarov January 15, 2024 13:53
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@czp13 czp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes and the Javadocs look good to me. I have found some resemblances to Bower in the test classes, but I guess those need to stay until we completely get rid of it.

@tepi
Copy link
Contributor Author

tepi commented Jan 16, 2024

The code changes and the Javadocs look good to me. I have found some resemblances to Bower in the test classes, but I guess those need to stay until we completely get rid of it.

Yes, there are still tests remaining and also some private methods referring to bower/compatibility mode in flow code. But once all the public references are deprecated we can eventually remote the internal/private things as well without breaking anything.

@czp13
Copy link
Contributor

czp13 commented Jan 16, 2024

Yes, there are still tests remaining and also some private methods referring to bower/compatibility mode in flow code. But once all the public references are deprecated we can eventually remote the internal/private things as well without breaking anything.

Thanks, Tepi! This makes 100% sense, let's move incrementally as you said.

I am happy to approve and merge, but of course, we can wait for an actual flow member and not an ex-flow member for visibility :D

@mshabarov mshabarov merged commit aebdfa1 into 2.10 Jan 16, 2024
@mshabarov mshabarov deleted the fix/deprecate-htmlimport branch January 16, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants