Skip to content

Conversation

mcollovati
Copy link
Collaborator

Description

Limits the number of requested items from backend to a given threshold of ten pages. Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Jan 9, 2024
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 9, 2024

Test Results

1 055 files  ± 0  1 055 suites  ±0   1h 14m 15s ⏱️ - 2m 34s
6 798 tests + 1  6 753 ✅ + 1  45 💤 ±0  0 ❌ ±0 
7 098 runs   - 13  7 042 ✅  - 13  56 💤 ±0  0 ❌ ±0 

Results for commit 7188d1d. ± Comparison against base commit 9a593fc.

@mshabarov mshabarov merged commit 94bb7d0 into main Jan 10, 2024
@mshabarov mshabarov deleted the issues/18403_hierarchical_datacommunicator_rangelimit branch January 10, 2024 11:30
vaadin-bot pushed a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
vaadin-bot pushed a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
vaadin-bot pushed a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
vaadin-bot pushed a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mshabarov, when i performed cherry-pick to this commit to 2.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 94bb7d0
error: could not apply 94bb7d0... fix: limit the requested items to a given threshold (#18417)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot pushed a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @mshabarov, when i performed cherry-pick to this commit to 1.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 94bb7d0
error: could not apply 94bb7d0... fix: limit the requested items to a given threshold (#18417)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mcollovati added a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
@mcollovati
Copy link
Collaborator Author

Flow 1.0 does not have HierarchicalDataCommunicator, it was introduced in Flow 1.2. I'll remove the target label

vaadin-bot added a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403

Co-authored-by: Marco Collovati <marco@vaadin.com>
mcollovati added a commit that referenced this pull request Jan 10, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403

Co-authored-by: Marco Collovati <marco@vaadin.com>
mcollovati added a commit that referenced this pull request Jan 11, 2024
Limits the number of requested items from backend to a given threshold of ten pages.
Exactly the same as #12003, but applied to HierarchicalDataCommunicator.

Fixes #18403
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment