Skip to content

fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2021
Merged

fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) #12238

merged 2 commits into from
Nov 4, 2021

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Nov 2, 2021 •
edited
Loading

Description

Limits the number of requested items from backend to a given threshold of 1000 items.

(cherry picked from commit 0ec90bf)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mshabarov mshabarov changed the title fix: Limit the requested pages to a given threshold (#12003) fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) Nov 2, 2021
@pleku pleku self-requested a review November 2, 2021 12:33
pleku
pleku suggested changes Nov 2, 2021
View reviewed changes
Copy link

@pleku pleku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like discussed, it should be enough to just cap the limit to 1000 items fetched at once instead of trying to use page size.

@mshabarov
fix: Limit the requested pages to a given threshold (#12003)
92e229b 
Limits the number of requested items from backend to a given threshold of ten pages.

(cherry picked from commit 0ec90bf)
@mshabarov mshabarov requested a review from pleku November 2, 2021 13:54
@pleku pleku merged commit 5e8dd34 into 2.7 Nov 4, 2021
@pleku pleku deleted the cp/limit-items-2.7 branch November 4, 2021 11:58
@vaadin-bot
Copy link
Collaborator

Hi @mshabarov and @pleku, when i performed cherry-pick to this commit to 1.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 5e8dd34
error: could not apply 5e8dd34... fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) (#12238)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

mshabarov added a commit that referenced this pull request Nov 4, 2021
@mshabarov
fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) (…
2a50902 
…#12238)

Limits the number of requested items from backend to a given threshold of ten pages.

(cherry picked from commit 0ec90bf)
pleku pushed a commit that referenced this pull request Nov 4, 2021
@mshabarov
fix: Limit the requested pages to a given threshold (#12003)(CP: 2.7) (…
139b4fd 
…#12238) (#12275)

Limits the number of requested items from backend to a given threshold of ten pages.

(cherry picked from commit 0ec90bf)
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pleku pleku pleku approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cherry pick need to pick manually 1.0 Released with Platform 14.7.4 target/1.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshabarov @vaadin-bot @pleku