Skip to content

Commit 1f56554

Browse files
authored
fix: prevent deletion of css.generated.js files (#21893)
Prevents frontend compilation failures on hot reload caused by the deletion of css.generated.js and css.generated.d.ts generated files when prepare frontend task is executed. Fixes #21892
1 parent 838f496 commit 1f56554

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRemoveOldFrontendGeneratedFiles.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,10 @@ private Predicate<Path> isKnownUnhandledFile() {
155155
frontendGeneratedFolder.resolve("file-routes.ts")));
156156
knownFiles.add(normalizePath(
157157
frontendGeneratedFolder.resolve("file-routes.json")));
158+
knownFiles.add(normalizePath(
159+
frontendGeneratedFolder.resolve("css.generated.js")));
160+
knownFiles.add(normalizePath(
161+
frontendGeneratedFolder.resolve("css.generated.d.ts")));
158162
knownFiles.addAll(hillaGeneratedFiles());
159163
return path -> knownFiles.contains(path) || path.getFileName()
160164
.toString().matches("theme(\\.(js|d\\.ts)|-.*\\.generated.js)");

flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskRemoveOldFrontendGeneratedFilesTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,12 @@ public void execute_knownFiles_notDeleted() throws Exception {
161161
"generated-flow-webcomponent-imports.js"))
162162
.toFile(),
163163
new File(generatedFolder, "routes.tsx"),
164-
new File(generatedFolder, "routes.ts"), generatedFolder.toPath()
165-
.resolve(Path.of("flow", "Flow.tsx")).toFile(),
166-
new File(generatedFolder, "file-routes.ts"));
164+
new File(generatedFolder, "routes.ts"),
165+
generatedFolder.toPath().resolve(Path.of("flow", "Flow.tsx"))
166+
.toFile(),
167+
new File(generatedFolder, "file-routes.ts"),
168+
new File(generatedFolder, "css.generated.js"),
169+
new File(generatedFolder, "css.generated.d.ts"));
167170
for (File file : knownFiles) {
168171
file.getParentFile().mkdirs();
169172
Files.writeString(file.toPath(), "TEST");

0 commit comments

Comments
 (0)