chore: do not load Lumo CSS in dev pages by default #9997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66386a1 to
f92a4e2
Compare
web-padawan
commented
Aug 14, 2025
| body = body.replace('</title>', '</title><link rel="stylesheet" href="/packages/aura/aura.css" />'); | ||
| } | ||
|
|
||
| if (theme === 'base' && context.response.is('html', 'js')) { |
There was a problem hiding this comment.
This change is needed to only remove CSS files matching ../ for base styles, but allow using relative imports such as ../packages/aura/aura.css which is planned to be used in particular in aura.html file.
jouni
approved these changes
Aug 14, 2025
59c7aed to
c7a3c23
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #9996
yarn start:lumoyarn start:auraType of change