fix: add CSS to make Lumo dialog content overflow work #9993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Aug 13, 2025
| @@ -77,10 +73,12 @@ | |||
| min-width: 12em; /* matches the default <vaadin-text-field> width */ | |||
| padding: var(--lumo-space-l); | |||
| flex: 1; | |||
| min-height: 0; | |||
There was a problem hiding this comment.
This is the actual fix.
web-padawan
commented
Aug 13, 2025
| @@ -65,10 +65,6 @@ | |||
| display: none !important; | |||
| } | |||
|
|
|||
| :host(:is([has-title], [has-header], [has-footer])) [part='content'] { | |||
There was a problem hiding this comment.
Not sure if we still need this at all after the change in #9903, maybe could be removed altogether.
Seems like this override was supposed to cover height: 100% in the resizable overlay styles.
There was a problem hiding this comment.
UPD: removed it from this PR.
05457c0 to
4eed10c
Compare
|
sissbruecker
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9992
Type of change