docs: update popover JSDoc to reduce mentions of the overlay #9983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Aug 13, 2025
| @@ -152,20 +152,20 @@ declare class Popover extends PopoverPositionMixin(PopoverTargetMixin(ThemePrope | |||
| hoverDelay: number; | |||
|
|
|||
| /** | |||
| * True if the popover overlay is opened, false otherwise. | |||
| * True if the popover is visible and available for interaction. | |||
There was a problem hiding this comment.
Adjusted wording based on the MDN description of <dialog open>:
Indicates that the dialog box is active and is available for interaction.
There was a problem hiding this comment.
Some additional things that could be cleaned up:
Set the height of the overlay.
Set the width of the overlay.
popoverThe reference to thevaadin-popoverelement (overlay host).
This also enables trapping focus inside the overlay.
2bdf8fd to
d3c7121
Compare
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
|
sissbruecker
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced some mentions of the
overlaywith thepopoveras the overlay is more of implementation detail in V25.Also updated JSDoc for
noCloseOnEscto match the new behavior after changing to global listener in #9972.Type of change