refactor: update popover to use global overlay listeners #9972
+122
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27bd680 to
c47d81b
Compare
|
web-padawan
commented
Aug 12, 2025
| @@ -692,17 +670,11 @@ class Popover extends PopoverPositionMixin( | |||
| * @private | |||
| */ | |||
| __onGlobalKeyDown(event) { | |||
| // Modal popover uses overlay logic for Esc key and focus trap. | |||
| // Modal popover uses overlay logic focus trap. | |||
There was a problem hiding this comment.
Seems like we still need this part for modeless popover but I removed closing logic.
sissbruecker
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
vaadin-popoverto use globalOverlayMixinoutside click listener both for modal / modeless.This makes it possible to prevent closing on outside click by preventing
vaadin-overlay-closeevent.Type of change