Skip to content

feat: add hasChildren property to grid row model #9956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2025
Merged

feat: add hasChildren property to grid row model #9956

merged 3 commits into from
Aug 12, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Aug 8, 2025 •
edited
Loading

Description

Adds a new hasChildren property to the grid row model, indicating whether the row has children. Having this property in the row model will allow Flow TreeGrid to stop passing children as a separate Lit renderer property in addHierarchyColumn and use model.hasChildren instead. This will in turn prevent the transmission of duplicate information and slightly reduce network traffic

Type of change

  • Feature

@vursen vursen changed the title feat: add expandable property to row model feat: add expandable state to row model Aug 8, 2025
@vursen vursen changed the title feat: add expandable state to row model feat: add expandable state to grid row model Aug 8, 2025
web-padawan
web-padawan reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add new property to this table in .js and .d.ts files:

web-components/packages/grid/src/vaadin-grid.js

Lines 87 to 90 in f5aa748

* The following properties are available in the `model` argument:
*
* Property name | Type | Description
* --------------|------|------------

sissbruecker
sissbruecker reviewed Aug 11, 2025
View reviewed changes
@vursen vursen changed the title feat: add expandable state to grid row model feat: add hasChildren property to grid row model Aug 11, 2025
@vursen
Copy link
Contributor Author

vursen commented Aug 11, 2025

Let's also add new property to this table in .js and .d.ts files:

Thanks, done.

@vursen vursen force-pushed the add-expandable-property-to-row-model branch from de7ad44 to e6656fe Compare August 11, 2025 09:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@web-padawan web-padawan removed the request for review from ugur-vaadin August 12, 2025 06:33
@vursen vursen merged commit a47e6ed into main Aug 12, 2025
10 of 12 checks passed
@vursen vursen deleted the add-expandable-property-to-row-model branch August 12, 2025 06:33
@vursen vursen mentioned this pull request Aug 12, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vursen @sissbruecker @web-padawan