refactor: update grid-pro CSS to not use registerStyles #9953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Aug 8, 2025
| @@ -48,7 +48,6 @@ const gridPro = css` | |||
|
|
|||
| /* Indicate read-only cells */ | |||
|
|
|||
| /* prettier-ignore */ | |||
There was a problem hiding this comment.
This seems unnecessary, Prettier doesn't complain about the line length.
web-padawan
commented
Aug 8, 2025
| @@ -37,14 +37,14 @@ | |||
|
|
|||
| /* prettier-ignore */ | |||
| :host([theme~='highlight-read-only-cells']) [tabindex]:not([part~='editable-cell']):not([part~='header-cell']):not([part~='footer-cell']) { | |||
| background-image: repeating-linear-gradient( | |||
There was a problem hiding this comment.
Fixed incorrect formatting not reported due to prettier-ignore above.
|
vursen
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
vaadin-grid-proto not useregisterStyles()API and instead moved CSS to base / Lumo styles.Type of change