Skip to content

fix: do not throw on closing popover when target is not set #9942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

fix: do not throw on closing popover when target is not set #9942

merged 1 commit into from
Aug 8, 2025

Conversation

web-padawan
Copy link
Member

Description

Added missing check for this.target to avoid following error:

      TypeError: Cannot read properties of null (reading 'style')
        at Popover.__onOverlayClosed (packages/popover/src/vaadin-popover.js:990:35)
        at EventPart.handleEvent (node_modules/lit-html/src/lit-html.ts:2105:28)

Type of change

  • Bugfix

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@web-padawan web-padawan mentioned this pull request Aug 8, 2025
Merged
@web-padawan web-padawan removed the request for review from sissbruecker August 8, 2025 09:59
@web-padawan web-padawan merged commit df8ba7f into main Aug 8, 2025
9 checks passed
@web-padawan web-padawan deleted the fix/popover-modal-target branch August 8, 2025 09:59
vaadin-bot pushed a commit that referenced this pull request Aug 8, 2025
@web-padawan @vaadin-bot
fix: do not throw on closing popover when target is not set (#9942)
c6faff5
vaadin-bot pushed a commit that referenced this pull request Aug 8, 2025
@web-padawan @vaadin-bot
fix: do not throw on closing popover when target is not set (#9942)
9c6e815
web-padawan added a commit that referenced this pull request Aug 8, 2025
@vaadin-bot @web-padawan
fix: do not throw on closing popover when target is not set (#9942) (#…
b0980eb 
…9946)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Aug 8, 2025
@vaadin-bot @web-padawan
fix: do not throw on closing popover when target is not set (#9942) (#…
8f5484f 
…9947)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.7 cherry-picked-24.8 target/24.7 target/24.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vursen @vaadin-bot