fix: use new padding and gap base style properties in various components #9939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
reviewed
Aug 7, 2025
| @@ -42,7 +42,7 @@ export const tabSheetStyles = [ | |||
| position: relative; | |||
| flex: 1; | |||
| box-sizing: border-box; | |||
| padding: var(--vaadin-tabsheet-padding, var(--vaadin-padding-s)); | |||
| padding: var(--vaadin-tabsheet-padding, var(--vaadin-padding-l)); | |||
There was a problem hiding this comment.
This would make the content / prefix look a bit misaligned, which is especially noticeable in the no-border screenshot. Not a blocker since padding is easily configurable with a custom property anyway.
There was a problem hiding this comment.
Yeah, I contemplated on this, and it was a very on-the-spot judgement call to use a bigger padding on the content. Let’s see if it holds up with Aura, or if we want to adjust it.
web-padawan
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the layout of these components: