refactor!: remove overlayClass property from overlay components #9926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After refactoring overlay-based components to keep their overlay in the shadow root, the
overlayClass
property will not be functional anymore, as the classes would be applied to the element in a shadow root. Instead, the regularclass
property should now be used to target overlays for styling.The following components are affected:
vaadin-avatar-group
vaadin-confirm-dialog
vaadin-context-menu
vaadin-combo-box
vaadin-date-picker
vaadin-date-time-picker
vaadin-dialog
vaadin-login-overlay
vaadin-menu-bar
vaadin-multi-select-combo-box
vaadin-popover
vaadin-select
vaadin-time-picker
vaadin-tooltip
The exception is
vaadin-notification
, for whichoverlayClass
still works as before.Part of #9742
Type of change