fix: add :root to charts CSS selector to fix exporting
#9907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Aug 6, 2025
When the user uses the exporting/print functionality in a `vaadin-chart`, the component briefly copies the CSS in the shadow root to the `body`. The CSS properties defined insinde the `:host` won't work in that case and the exported will result in a dark image.
5de7d89 to
390f58f
Compare
web-padawan
approved these changes
Aug 6, 2025
|
There are still visual test failures: |
I am trying to understand what is causing this issue, as running the update screenshots task locally won't give any difference. |
f764961 to
5e17e9b
Compare
5e17e9b to
366e135
Compare
|
web-padawan
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user uses the exporting/print functionality in a
vaadin-chart, the component briefly copies the CSS in the shadow root to thebody. The CSS properties defined insinde the:hostwon't work in that case and the exported will result in a dark image.