fix: defer detect layout mode until updates are done #9889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Aug 5, 2025
| @@ -524,7 +524,7 @@ class MasterDetailLayout extends SlotStylesMixin(ResizeMixin(ElementMixin(Themab | |||
| */ | |||
| async _finishTransition() { | |||
| // Detect new layout mode after DOM has been updated | |||
| this.__detectLayoutMode(); | |||
| queueMicrotask(() => this.__detectLayoutMode()); | |||
There was a problem hiding this comment.
The delay is a bit concerning, as the promise resolved below triggers the view transition to start, at which point we want the attributes set by __detectLayoutMode to be present. However the timing seems to work out at the moment in both Chrome and Safari, so I'm fine with it. Might be of interest in case view transitions stop working properly at some point.
|
sissbruecker
approved these changes
Aug 6, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 6, 2025
* fix: defer detect layout mode until updates are done * chore: add comment on why the calculation is deferred * test: specify litelement in test name
web-padawan
pushed a commit
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Under some conditions, the dimension updates for the details are not completed when the new layout mode is determined. This PR wraps the call in
queueMicrotaskin order to defer it until all the dimensions are updated.Fixes #8969
Type of change
Checklist