fix: adjust row and col count base on Grid state #9872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply some adjustments to how the `aria-rowcount`/`aria-colcount` values are measured. The changes in this PR are: - Fix the wrong usage of `headerRenderer` at the method responsible of counting the number of footer rows - Add a call to `_a11yUpdateGridSize` in the `__updateHeaderFooterRowVisibility` method to recalculate the number of rows/cols when the renderers change - If empty-state is used and it's active, it is counted as a row - If the grid has no items and no header/footer is rendered, then the number of columns is adjusted accordingly Fixes #9081
There was a problem hiding this comment.
Pull Request Overview
This PR fixes accessibility issues in the Grid component by correcting how aria-rowcount and aria-colcount values are calculated based on the grid's state, including header/footer visibility and empty state handling.
- Fixed incorrect method call for counting footer rows (was using
headerRendererinstead offooterRenderer) - Added grid size recalculation when header/footer visibility changes
- Improved column count calculation to handle empty state scenarios appropriately
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/grid/src/vaadin-grid-a11y-mixin.js | Fixed footer row counting bug and improved aria-rowcount/aria-colcount calculation logic with empty state support |
| packages/grid/src/vaadin-grid-mixin.js | Added call to recalculate grid size when header/footer visibility changes |
| packages/grid/test/accessibility.test.js | Added test cases to verify correct aria attribute values in various grid states |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vursen
reviewed
Aug 4, 2025
| } | ||
|
|
||
| /** @private */ | ||
| _a11yUpdateGridSize(size, _columnTree) { | ||
| _a11yUpdateGridSize(size, _columnTree, __emptyState) { |
There was a problem hiding this comment.
Suggested change
| _a11yUpdateGridSize(size, _columnTree, __emptyState) { | |
| _a11yUpdateGridSize(size, _columnTree, emptyState) { |
There was a problem hiding this comment.
Done in 33c75a2.
f09c068 to
33c75a2
Compare
ugur-vaadin
approved these changes
Aug 4, 2025
DiegoCardoso
commented
Aug 4, 2025
|
vursen
approved these changes
Aug 5, 2025
web-padawan
approved these changes
Aug 5, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
web-padawan
pushed a commit
that referenced
this pull request
Aug 5, 2025
… (#9891) Co-authored-by: Diego Cardoso <diego@vaadin.com>
web-padawan
pushed a commit
that referenced
this pull request
Aug 5, 2025
… (#9892) Co-authored-by: Diego Cardoso <diego@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply some adjustments to how the
aria-rowcount/aria-colcountvalues are measured. The changes in this PR are:headerRendererat the method responsible of counting the number of footer rows_a11yUpdateGridSizein the__updateHeaderFooterRowVisibilitymethod to recalculate the number of rows/cols when the renderers changeBelow is a table with the possible states and how the amount of
aria-rowcountandaria-colcountare reflected:B: is the number of body rows, H of header rows, and F of footer rows
aria-rowcountaria-colcountFixes #9081
Type of change