Skip to content

Conversation

web-padawan
Copy link
Member

Description

This should fix the error discovered in React wrappers, see vaadin/react-components#344.

The intersection 'ClearButtonMixinClass & DelegateFocusMixinClass & DelegateStateMixinClass & DisabledMixinClass & ... 15 more ... & HTMLElement' was reduced to 'never' because property 'autocorrect' has conflicting types in some constituents.

The reason is that autocorrect property was added in microsoft/TypeScript#61647:

    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/autocorrect) */
    autocorrect: boolean;

Type of change

  • Bugfix

Copy link

sonarqubecloud bot commented Aug 1, 2025

@web-padawan web-padawan merged commit 1b8bf50 into main Aug 1, 2025
10 checks passed
@web-padawan web-padawan deleted the fix/autocorrect-typings branch August 1, 2025 13:07
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 1b8bf50
error: could not apply 1b8bf50... fix: bump TypeScript to 5.9, remove autocorrect property override (#9870)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 1b8bf50
error: could not apply 1b8bf50... fix: bump TypeScript to 5.9, remove autocorrect property override (#9870)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants