Some issues with this PR that need to be addressed:

• Since refactor!: update dialog to use native popover #9807 vaadin-dialog-overlay is not exposed anymore, and instead vaadin-dialog is the element to target for styling. Since that one already has the draggable attribute, this change is not required in main / v25. It could still target v24.9 though, for that the target branch needs to be changed.
• The PR title does not match the contribution guidelines.
• The PR doesn't have tests as required by the contribution guidelines.

@mukherjeesudebi Can you please try to address these?

Edit: Just noticed that there is no 24.9 branch yet. Will check if this can be shipped in a v24.8 patch.

I think it's such a small change that we could ship it in 24.8 (although we'll need to create 24.9 branch eventually).

We also need to update the Lit version in 24.8 branch for consistency.

If I run yarn test --group dialog in my local workspace then all tests are passing. Not able to understand why it fails in the PR. Am I missing anything or doing something wrong?

@mukherjeesudebi You need to make the same change in packages/dialog/src/vaadin-lit-dialog.js. CI runs the same tests for both vaadin-dialog.js and vaadin-lit-dialog.js. It fails for vaadin-lit-dialog.js because the attribute is not there.

Edit: Note that the Lit syntax for setting a boolean attribute is slightly different, but there is an example with resizable.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This ticket/PR has been released with Vaadin 24.8.6.

This ticket/PR has been released with Vaadin 24.9.0-alpha4.