test: add workaround to fix failing grid-pro custom-field test #9673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Jul 10, 2025
| @@ -63,6 +63,8 @@ describe('grid-pro custom editor', () => { | |||
| // NOTE: using `innerHTML` doesn't work due to the timing issue in custom-field | |||
| // See https://github.com/vaadin/web-components/issues/7871 | |||
| const field = document.createElement('vaadin-custom-field'); | |||
| // TODO: workaround sendMouse test failing locally in Chrome | |||
| field.style.lineHeight = '1.5'; | |||
There was a problem hiding this comment.
Looks like the grid cells are rendering with 0 height, which is causing this issue. I would suggest adding the same fix used in other tests:
vaadin-grid-pro::part(cell) {
min-height: 36px;
}
|
vursen
approved these changes
Jul 10, 2025
DiegoCardoso
approved these changes
Jul 10, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following test fails locally but for some reason passes in CI:
I wasn't able to figure out why it happens but it's somehow related to removal of Lumo from ITs.
After some debugging I figured out that test passes after adding
line-heightto the field.Type of change