refactor: update dashboard styles, fix unit tests to use src version #9563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
approved these changes
Jun 26, 2025
| @@ -25,7 +24,7 @@ const [defaultSpacing, defaultMinimumColumnWidth] = (() => { | |||
| document.body.appendChild(div); | |||
| div.style.width = '1rem'; | |||
| const minColWidth = div.offsetWidth * 25; | |||
| div.style.width = 'var(--lumo-space-m)'; | |||
| div.style.width = '1rem'; // var(--lumo-space-m) | |||
There was a problem hiding this comment.
Suggested change
| div.style.width = '1rem'; // var(--lumo-space-m) | |
| div.style.width = '1rem'; |
Or was leaving a reference intentional?
There was a problem hiding this comment.
Yep, I decided to leave it as a reference. We probably should change it later when adding base styles to use some gap custom CSS property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated dashboard tests to use
srcversion instead of Lumo, which fixes errors noticeable with--theme=base:min-heightto the content part as otherwise it has 0 heightmin-widthto dashboard button as otherwise it has 0 widthType of change