test: remove Lit tests for controllers and mixins from 24.9 #10029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Aug 19, 2025
|
This ticket/PR has been released with Vaadin 24.9.0-alpha7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We no longer have Lit based components in V24.9 except a few ones like Popover, SideNav and Dashboard.
They only use a small subset of mixins like
DisabledMixinwhich doesn't have any Lit specific logic.IMO it's ok to remove LitElement tests for these controllers and mixins and only keep them tested with Polymer.
One exception where I preserved Lit tests is
DirMixinwhich does have some LitElement specific logic.Type of change