chore: fix some incorrect JSDoc found by eslint-plugin-jsdoc #10012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
commented
Aug 18, 2025
| @@ -16,14 +16,14 @@ export const ItemsMixin = (superClass) => | |||
| * @typedef ContextMenuItem | |||
| * @type {object} | |||
| * @property {string} text - Text to be set as the menu item component's textContent | |||
| * @property {union: string | object} component - The component to represent the item. | |||
| * @property {string | HTMLElement} component - The component to represent the item. | |||
There was a problem hiding this comment.
The union: syntax was not recognized by TypeScript, changing to string | HTMLElement makes it work.
web-padawan
commented
Aug 18, 2025
| @@ -16,7 +16,6 @@ import { datePickerYearStyles } from './styles/vaadin-date-picker-year-base-styl | |||
| * @customElement | |||
| * @extends HTMLElement | |||
| * @mixes ThemableMixin | |||
| * @mixes DatePickerYearMixin | |||
There was a problem hiding this comment.
I forgot to remove this when inlining the mixin in #9430.
vursen
approved these changes
Aug 18, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some issues found by trying
eslint-plugin-jsdoclike incorrect / missing@paramannotations etc.Type of change