chore: add charts demo listing page #10009
Conversation
Add a similar `index.html` page that is available in `/dev/index.html` to `/dev/charts/` to make it easier to move between charts dev pages.
web-dev-server.config.js
Outdated
| @@ -78,6 +78,8 @@ export default { | |||
| // Index page listing | |||
| if (['/dev/index.html', '/dev', '/dev/'].includes(context.path)) { | |||
| body = generateListing(body, './dev', context.path); | |||
| } else if (['/dev/charts/index.html', '/dev/charts', '/dev/charts/'].includes(context.path)) { | |||
| body = generateListing(body, './dev/charts', context.path); | |||
There was a problem hiding this comment.
We should also update code in generateListing to add <base href> tag for /dev/charts without trailing slash to make sure relative import for common.js works properly.
There was a problem hiding this comment.
Fixed. I refactored it a bit to use regex to avoid duplicating the same logic. Let me know what you think.
There was a problem hiding this comment.
Looks good, but we also need to update this now to get correct listing when running yarn dev:start:
web-components/dev/rollup.config.js
Line 15 in 366c287
There was a problem hiding this comment.
I tried something, but it is not working well when the URL has a trailing slash (http://localhost:8000/charts/) because the links in the listing end up with .../charts/charts/... 🤔
There was a problem hiding this comment.
I see. IMO we can accept that /charts would not work and then just allow /charts/ and /charts/index.html.
There was a problem hiding this comment.
Removed logic for writing <base> for dev pages build (but preserved it for running yarn start).
Also modified generateListing() to list "charts" as a separate entry in the main index.html.
|
Description
Add a similar
index.htmlpage that is available in/dev/index.htmlto/dev/charts/to make it easier to move between charts dev pages.