Skip to content

Commit d776739

Browse files
authored
docs: deprecate popover renderer property and Lit directive (#9981)
1 parent bc04644 commit d776739

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed

packages/popover/src/lit/renderer-directives.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export class PopoverRendererDirective extends LitRendererDirective<Popover, Popo
5151
* @param renderer the renderer callback that returns a Lit template.
5252
* @param dependencies a single dependency or an array of dependencies
5353
* which trigger a re-render when changed.
54+
* @deprecated Add content elements as children of the popover using default slot
5455
*/
5556
export declare function popoverRenderer(
5657
renderer: PopoverLitRenderer,

packages/popover/src/lit/renderer-directives.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,6 @@ export class PopoverRendererDirective extends LitRendererDirective {
5656
* @param renderer the renderer callback that returns a Lit template.
5757
* @param dependencies a single dependency or an array of dependencies
5858
* which trigger a re-render when changed.
59+
* @deprecated Add content elements as children of the popover using default slot
5960
*/
6061
export const popoverRenderer = directive(PopoverRendererDirective);

packages/popover/src/vaadin-popover.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,8 @@ declare class Popover extends PopoverPositionMixin(PopoverTargetMixin(ThemePrope
170170
*
171171
* - `root` The root container DOM element. Append your content to it.
172172
* - `popover` The reference to the `vaadin-popover` element (overlay host).
173+
*
174+
* @deprecated Add content elements as children of the popover using default slot
173175
*/
174176
renderer: PopoverRenderer | null | undefined;
175177

@@ -231,6 +233,8 @@ declare class Popover extends PopoverPositionMixin(PopoverTargetMixin(ThemePrope
231233
* While performing the update, it invokes the renderer passed in the `renderer` property.
232234
*
233235
* It is not guaranteed that the update happens immediately (synchronously) after it is requested.
236+
*
237+
* @deprecated Add content elements as children of the popover using default slot
234238
*/
235239
requestContentUpdate(): void;
236240

packages/popover/src/vaadin-popover.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,8 @@ class Popover extends PopoverPositionMixin(
340340
*
341341
* - `root` The root container DOM element. Append your content to it.
342342
* - `popover` The reference to the `vaadin-popover` element (overlay host).
343+
*
344+
* @deprecated Use the content in the `vaadin-popover` via default slot
343345
*/
344346
renderer: {
345347
type: Object,
@@ -515,6 +517,8 @@ class Popover extends PopoverPositionMixin(
515517
* While performing the update, it invokes the renderer passed in the `renderer` property.
516518
*
517519
* It is not guaranteed that the update happens immediately (synchronously) after it is requested.
520+
*
521+
* @deprecated Add content elements as children of the popover using default slot
518522
*/
519523
requestContentUpdate() {
520524
if (!this.renderer || !this._overlayElement) {

0 commit comments

Comments
 (0)