Skip to content

Commit 9492abb

Browse files
authored
docs: remove mentions of overlay in dialog and confirm-dialog (#9986)
1 parent f583430 commit 9492abb

8 files changed

+28
-32
lines changed

packages/confirm-dialog/src/vaadin-confirm-dialog-mixin.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export declare function ConfirmDialogMixin<T extends Constructor<HTMLElement>>(
3636

3737
export declare class ConfirmDialogMixinClass {
3838
/**
39-
* Sets the `aria-describedby` attribute of the overlay element.
39+
* Sets the `aria-describedby` attribute of the dialog.
4040
*
4141
* By default, the text contents of all elements inside the message area
4242
* are combined into the `aria-description` attribute. However, there are
@@ -49,7 +49,7 @@ export declare class ConfirmDialogMixinClass {
4949
accessibleDescriptionRef: string | null | undefined;
5050

5151
/**
52-
* True if the overlay is currently displayed.
52+
* True if the dialog is visible and available for interaction.
5353
*/
5454
opened: boolean;
5555

packages/confirm-dialog/src/vaadin-confirm-dialog-mixin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const ConfirmDialogMixin = (superClass) =>
1616
static get properties() {
1717
return {
1818
/**
19-
* Sets the `aria-describedby` attribute of the overlay element.
19+
* Sets the `aria-describedby` attribute of the dialog.
2020
*
2121
* By default, the text contents of all elements inside the message area
2222
* are combined into the `aria-description` attribute. However, there are
@@ -30,7 +30,7 @@ export const ConfirmDialogMixin = (superClass) =>
3030
},
3131

3232
/**
33-
* True if the overlay is currently displayed.
33+
* True if the dialog is visible and available for interaction.
3434
* @type {boolean}
3535
*/
3636
opened: {

packages/dialog/src/vaadin-dialog-base-mixin.d.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export declare function DialogBaseMixin<T extends Constructor<HTMLElement>>(
1111

1212
export declare class DialogBaseMixinClass {
1313
/**
14-
* True if the overlay is currently displayed.
14+
* True if the dialog is visible and available for interaction.
1515
*/
1616
opened: boolean;
1717

@@ -41,22 +41,20 @@ export declare class DialogBaseMixinClass {
4141
overlayRole: string;
4242

4343
/**
44-
* Set the distance of the overlay from the top of its container.
44+
* Set the distance of the dialog from the top of the viewport.
4545
* If a unitless number is provided, pixels are assumed.
4646
*
47-
* Note that the overlay top edge may not be the same as the viewport
48-
* top edge (e.g. the Lumo theme defines some spacing to prevent the
49-
* overlay from stretching all the way to the top of the viewport).
47+
* Note that the dialog uses an internal container that has some
48+
* additional spacing, which can be overridden by the theme.
5049
*/
5150
top: string;
5251

5352
/**
54-
* Set the distance of the overlay from the left of its container.
53+
* Set the distance of the dialog from the left of the viewport.
5554
* If a unitless number is provided, pixels are assumed.
5655
*
57-
* Note that the overlay left edge may not be the same as the viewport
58-
* left edge (e.g. the Lumo theme defines some spacing to prevent the
59-
* overlay from stretching all the way to the left of the viewport).
56+
* Note that the dialog uses an internal container that has some
57+
* additional spacing, which can be overridden by the theme.
6058
*/
6159
left: string;
6260
}

packages/dialog/src/vaadin-dialog-base-mixin.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const DialogBaseMixin = (superClass) =>
1212
static get properties() {
1313
return {
1414
/**
15-
* True if the overlay is currently displayed.
15+
* True if the dialog is visible and available for interaction.
1616
* @type {boolean}
1717
*/
1818
opened: {
@@ -53,24 +53,22 @@ export const DialogBaseMixin = (superClass) =>
5353
},
5454

5555
/**
56-
* Set the distance of the overlay from the top of its container.
56+
* Set the distance of the dialog from the top of the viewport.
5757
* If a unitless number is provided, pixels are assumed.
5858
*
59-
* Note that the overlay top edge may not be the same as the viewport
60-
* top edge (e.g. the Lumo theme defines some spacing to prevent the
61-
* overlay from stretching all the way to the top of the viewport).
59+
* Note that the dialog uses an internal container that has some
60+
* additional spacing, which can be overridden by the theme.
6261
*/
6362
top: {
6463
type: String,
6564
},
6665

6766
/**
68-
* Set the distance of the overlay from the left of its container.
67+
* Set the distance of the dialog from the left of the viewport.
6968
* If a unitless number is provided, pixels are assumed.
7069
*
71-
* Note that the overlay left edge may not be the same as the viewport
72-
* left edge (e.g. the Lumo theme defines some spacing to prevent the
73-
* overlay from stretching all the way to the left of the viewport).
70+
* Note that the dialog uses an internal container that has some
71+
* additional spacing, which can be overridden by the theme.
7472
*/
7573
left: {
7674
type: String,

packages/dialog/src/vaadin-dialog-renderer-mixin.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export declare class DialogRendererMixinClass {
2727
* and the elements created by the renderer will be placed next to
2828
* each other, with the title coming first.
2929
*
30-
* When `headerTitle` is set, the attribute `has-title` is added to the overlay element.
30+
* When `headerTitle` is set, the attribute `has-title` is set on the dialog.
3131
* @attr {string} header-title
3232
*/
3333
headerTitle: string | null | undefined;
@@ -43,7 +43,7 @@ export declare class DialogRendererMixinClass {
4343
* and the elements created by the renderer will be placed next to
4444
* each other, with the title coming first.
4545
*
46-
* When `headerRenderer` is set, the attribute `has-header` is added to the overlay element.
46+
* When `headerRenderer` is set, the attribute `has-header` is set on the dialog.
4747
*/
4848
headerRenderer: DialogRenderer | null | undefined;
4949

@@ -54,7 +54,7 @@ export declare class DialogRendererMixinClass {
5454
* - `root` The root container DOM element. Append your content to it.
5555
* - `dialog` The reference to the `<vaadin-dialog>` element.
5656
*
57-
* When `footerRenderer` is set, the attribute `has-footer` is added to the overlay element.
57+
* When `footerRenderer` is set, the attribute `has-footer` is set on the dialog.
5858
*/
5959
footerRenderer: DialogRenderer | null | undefined;
6060

packages/dialog/src/vaadin-dialog-renderer-mixin.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const DialogRendererMixin = (superClass) =>
3030
* and the elements created by the renderer will be placed next to
3131
* each other, with the title coming first.
3232
*
33-
* When `headerTitle` is set, the attribute `has-title` is added to the overlay element.
33+
* When `headerTitle` is set, the attribute `has-title` is set on the dialog.
3434
* @attr {string} header-title
3535
*/
3636
headerTitle: String,
@@ -46,7 +46,7 @@ export const DialogRendererMixin = (superClass) =>
4646
* and the elements created by the renderer will be placed next to
4747
* each other, with the title coming first.
4848
*
49-
* When `headerRenderer` is set, the attribute `has-header` is added to the overlay element.
49+
* When `headerRenderer` is set, the attribute `has-header` is set on the dialog.
5050
* @type {DialogRenderer | undefined}
5151
*/
5252
headerRenderer: {
@@ -60,7 +60,7 @@ export const DialogRendererMixin = (superClass) =>
6060
* - `root` The root container DOM element. Append your content to it.
6161
* - `dialog` The reference to the `<vaadin-dialog>` element.
6262
*
63-
* When `footerRenderer` is set, the attribute `has-footer` is added to the overlay element.
63+
* When `footerRenderer` is set, the attribute `has-footer` is set on the dialog.
6464
* @type {DialogRenderer | undefined}
6565
*/
6666
footerRenderer: {

packages/dialog/src/vaadin-dialog-size-mixin.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ export declare function DialogSizeMixin<T extends Constructor<HTMLElement>>(
1111

1212
export declare class DialogSizeMixinClass {
1313
/**
14-
* Set the width of the overlay.
14+
* Set the width of the dialog.
1515
* If a unitless number is provided, pixels are assumed.
1616
*/
1717
width: string | null;
1818

1919
/**
20-
* Set the height of the overlay.
20+
* Set the height of the dialog.
2121
* If a unitless number is provided, pixels are assumed.
2222
*/
2323
height: string | null;

packages/dialog/src/vaadin-dialog-size-mixin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ export const DialogSizeMixin = (superClass) =>
1212
static get properties() {
1313
return {
1414
/**
15-
* Set the width of the overlay.
15+
* Set the width of the dialog.
1616
* If a unitless number is provided, pixels are assumed.
1717
*/
1818
width: {
1919
type: String,
2020
},
2121

2222
/**
23-
* Set the height of the overlay.
23+
* Set the height of the dialog.
2424
* If a unitless number is provided, pixels are assumed.
2525
*/
2626
height: {

0 commit comments

Comments
 (0)