Skip to content

Commit 1d83057

Browse files
sissbrueckersissbruecker
authored
refactor!: remove overlayClass property from overlay components (#9926)
1 parent 2f92a31 commit 1d83057

File tree

72 files changed

+22
-619
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+22
-619
lines changed

‎packages/avatar-group/src/vaadin-avatar-group-mixin.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import type { Constructor } from '@open-wc/dedupe-mixin';
77
import type { AvatarI18n } from '@vaadin/avatar/src/vaadin-avatar.js';
88
import type { I18nMixinClass } from '@vaadin/component-base/src/i18n-mixin.js';
9-
import type { OverlayClassMixinClass } from '@vaadin/component-base/src/overlay-class-mixin.js';
109
import type { ResizeMixinClass } from '@vaadin/component-base/src/resize-mixin.js';
1110

1211
export interface AvatarGroupI18n extends AvatarI18n {
@@ -33,7 +32,6 @@ export declare function AvatarGroupMixin<T extends Constructor<HTMLElement>>(
3332
base: T,
3433
): Constructor<AvatarGroupMixinClass> &
3534
Constructor<I18nMixinClass<AvatarGroupI18n>> &
36-
Constructor<OverlayClassMixinClass> &
3735
Constructor<ResizeMixinClass> &
3836
T;
3937

‎packages/avatar-group/src/vaadin-avatar-group-mixin.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { html, render } from 'lit';
77
import { ifDefined } from 'lit/directives/if-defined.js';
88
import { announce } from '@vaadin/a11y-base/src/announce.js';
99
import { I18nMixin } from '@vaadin/component-base/src/i18n-mixin.js';
10-
import { OverlayClassMixin } from '@vaadin/component-base/src/overlay-class-mixin.js';
1110
import { ResizeMixin } from '@vaadin/component-base/src/resize-mixin.js';
1211
import { SlotController } from '@vaadin/component-base/src/slot-controller.js';
1312

@@ -29,10 +28,9 @@ const DEFAULT_I18N = {
2928
* @polymerMixin
3029
* @mixes I18nMixin
3130
* @mixes ResizeMixin
32-
* @mixes OverlayClassMixin
3331
*/
3432
export const AvatarGroupMixin = (superClass) =>
35-
class AvatarGroupMixinClass extends I18nMixin(DEFAULT_I18N, ResizeMixin(OverlayClassMixin(superClass))) {
33+
class AvatarGroupMixinClass extends I18nMixin(DEFAULT_I18N, ResizeMixin(superClass)) {
3634
static get properties() {
3735
return {
3836
/**

‎packages/avatar-group/test/dom/__snapshots__/avatar-group.test.snap.js

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -331,19 +331,3 @@ snapshots["vaadin-avatar-group opened overlay"] =
331331
`;
332332
/* end snapshot vaadin-avatar-group opened overlay */
333333

334-
snapshots["vaadin-avatar-group opened overlay class"] =
335-
`<vaadin-avatar-group-overlay
336-
class="avatar-group-overlay custom"
337-
exportparts="overlay, content"
338-
id="overlay"
339-
no-vertical-overlap=""
340-
popover="manual"
341-
start-aligned=""
342-
top-aligned=""
343-
>
344-
<slot name="overlay">
345-
</slot>
346-
</vaadin-avatar-group-overlay>
347-
`;
348-
/* end snapshot vaadin-avatar-group opened overlay class */
349-

‎packages/avatar-group/test/dom/avatar-group.test.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,5 @@ describe('vaadin-avatar-group', () => {
4949
it('overlay', async () => {
5050
await expect(group.$.overlay).dom.to.equalSnapshot(SNAPSHOT_CONFIG);
5151
});
52-
53-
it('overlay class', async () => {
54-
group.overlayClass = 'avatar-group-overlay custom';
55-
await nextUpdate(group);
56-
await expect(group.$.overlay).dom.to.equalSnapshot(SNAPSHOT_CONFIG);
57-
});
5852
});
5953
});

‎packages/avatar-group/test/typings/avatar-group.types.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import '../../vaadin-avatar-group.js';
22
import type { ElementMixinClass } from '@vaadin/component-base/src/element-mixin.js';
33
import type { I18nMixinClass } from '@vaadin/component-base/src/i18n-mixin.js';
4-
import type { OverlayClassMixinClass } from '@vaadin/component-base/src/overlay-class-mixin.js';
54
import type { ResizeMixinClass } from '@vaadin/component-base/src/resize-mixin.js';
65
import type { ThemableMixinClass } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
76
import type { AvatarGroupMixinClass } from '../../src/vaadin-avatar-group-mixin.js';
@@ -15,7 +14,6 @@ const group = document.createElement('vaadin-avatar-group');
1514
assertType<AvatarGroupItem[] | undefined>(group.items);
1615
assertType<number | null | undefined>(group.maxItemsVisible);
1716
assertType<AvatarGroupI18n>(group.i18n);
18-
assertType<string>(group.overlayClass);
1917

2018
// Item properties
2119
const item: AvatarGroupItem = group.items ? group.items[0] : {};
@@ -33,6 +31,5 @@ assertType<AvatarGroupI18n>({ activeUsers: { one: '1 user' } });
3331
assertType<AvatarGroupMixinClass>(group);
3432
assertType<ElementMixinClass>(group);
3533
assertType<I18nMixinClass<AvatarGroupI18n>>(group);
36-
assertType<OverlayClassMixinClass>(group);
3734
assertType<ResizeMixinClass>(group);
3835
assertType<ThemableMixinClass>(group);

‎packages/combo-box/src/vaadin-combo-box-base-mixin.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import type { Constructor } from '@open-wc/dedupe-mixin';
77
import type { DisabledMixinClass } from '@vaadin/a11y-base/src/disabled-mixin.js';
88
import type { FocusMixinClass } from '@vaadin/a11y-base/src/focus-mixin.js';
99
import type { KeyboardMixinClass } from '@vaadin/a11y-base/src/keyboard-mixin.js';
10-
import type { OverlayClassMixinClass } from '@vaadin/component-base/src/overlay-class-mixin.js';
1110
import type { InputMixinClass } from '@vaadin/field-base/src/input-mixin.js';
1211
import type { ValidateMixinClass } from '@vaadin/field-base/src/validate-mixin.js';
1312

@@ -18,7 +17,6 @@ export declare function ComboBoxBaseMixin<T extends Constructor<HTMLElement>>(
1817
Constructor<FocusMixinClass> &
1918
Constructor<InputMixinClass> &
2019
Constructor<KeyboardMixinClass> &
21-
Constructor<OverlayClassMixinClass> &
2220
Constructor<ValidateMixinClass> &
2321
T;
2422

‎packages/combo-box/src/vaadin-combo-box-base-mixin.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { FocusMixin } from '@vaadin/a11y-base/src/focus-mixin.js';
88
import { isElementFocused, isKeyboardActive } from '@vaadin/a11y-base/src/focus-utils.js';
99
import { KeyboardMixin } from '@vaadin/a11y-base/src/keyboard-mixin.js';
1010
import { isTouch } from '@vaadin/component-base/src/browser-utils.js';
11-
import { OverlayClassMixin } from '@vaadin/component-base/src/overlay-class-mixin.js';
1211
import { InputMixin } from '@vaadin/field-base/src/input-mixin.js';
1312
import { VirtualKeyboardController } from '@vaadin/field-base/src/virtual-keyboard-controller.js';
1413
import { ComboBoxPlaceholder } from './vaadin-combo-box-placeholder.js';
@@ -19,13 +18,10 @@ import { ComboBoxPlaceholder } from './vaadin-combo-box-placeholder.js';
1918
* @mixes FocusMixin
2019
* @mixes InputMixin
2120
* @mixes KeyboardMixin
22-
* @mixes OverlayClassMixin
2321
* @param {function(new:HTMLElement)} superClass
2422
*/
2523
export const ComboBoxBaseMixin = (superClass) =>
26-
class ComboBoxMixinBaseClass extends OverlayClassMixin(
27-
KeyboardMixin(InputMixin(DisabledMixin(FocusMixin(superClass)))),
28-
) {
24+
class ComboBoxMixinBaseClass extends KeyboardMixin(InputMixin(DisabledMixin(FocusMixin(superClass)))) {
2925
static get properties() {
3026
return {
3127
/**

‎packages/combo-box/src/vaadin-combo-box-mixin.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import type { Constructor } from '@open-wc/dedupe-mixin';
77
import type { DisabledMixinClass } from '@vaadin/a11y-base/src/disabled-mixin.js';
88
import type { FocusMixinClass } from '@vaadin/a11y-base/src/focus-mixin.js';
99
import type { KeyboardMixinClass } from '@vaadin/a11y-base/src/keyboard-mixin.js';
10-
import type { OverlayClassMixinClass } from '@vaadin/component-base/src/overlay-class-mixin.js';
1110
import type { InputMixinClass } from '@vaadin/field-base/src/input-mixin.js';
1211
import type { ValidateMixinClass } from '@vaadin/field-base/src/validate-mixin.js';
1312
import type { ComboBox } from './vaadin-combo-box.js';
@@ -26,7 +25,6 @@ export declare function ComboBoxMixin<TItem, T extends Constructor<HTMLElement>>
2625
Constructor<FocusMixinClass> &
2726
Constructor<InputMixinClass> &
2827
Constructor<KeyboardMixinClass> &
29-
Constructor<OverlayClassMixinClass> &
3028
Constructor<ValidateMixinClass> &
3129
T;
3230

‎packages/combo-box/src/vaadin-combo-box.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import type { FocusMixinClass } from '@vaadin/a11y-base/src/focus-mixin.js';
99
import type { KeyboardMixinClass } from '@vaadin/a11y-base/src/keyboard-mixin.js';
1010
import type { DelegateStateMixinClass } from '@vaadin/component-base/src/delegate-state-mixin.js';
1111
import type { ElementMixinClass } from '@vaadin/component-base/src/element-mixin.js';
12-
import type { OverlayClassMixinClass } from '@vaadin/component-base/src/overlay-class-mixin.js';
1312
import type { ClearButtonMixinClass } from '@vaadin/field-base/src/clear-button-mixin.js';
1413
import type { FieldMixinClass } from '@vaadin/field-base/src/field-mixin.js';
1514
import type { InputConstraintsMixinClass } from '@vaadin/field-base/src/input-constraints-mixin.js';
@@ -236,7 +235,6 @@ interface ComboBox<TItem = ComboBoxDefaultItem>
236235
PatternMixinClass,
237236
LabelMixinClass,
238237
KeyboardMixinClass,
239-
OverlayClassMixinClass,
240238
InputMixinClass,
241239
ClearButtonMixinClass,
242240
InputControlMixinClass,

‎packages/combo-box/test/dom/__snapshots__/combo-box.test.snap.js

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -481,23 +481,6 @@ snapshots["vaadin-combo-box host opened overlay shadow"] =
481481
`;
482482
/* end snapshot vaadin-combo-box host opened overlay shadow */
483483

484-
snapshots["vaadin-combo-box host opened overlay class"] =
485-
`<vaadin-combo-box-overlay
486-
class="combo-box-overlay custom"
487-
exportparts="overlay, content, loader"
488-
id="overlay"
489-
no-vertical-overlap=""
490-
opened=""
491-
popover="manual"
492-
start-aligned=""
493-
top-aligned=""
494-
>
495-
<slot name="overlay">
496-
</slot>
497-
</vaadin-combo-box-overlay>
498-
`;
499-
/* end snapshot vaadin-combo-box host opened overlay class */
500-
501484
snapshots["vaadin-combo-box host opened theme overlay"] =
502485
`<vaadin-combo-box-overlay
503486
exportparts="overlay, content, loader"

0 commit comments

Comments
 (0)