fix: do not trap focus when removing overlay while opening (#10042)

web-padawan · web-flow · commit 0703bd1bf410 · 2025-08-20T12:22:17.000+03:00
diff --git a/packages/overlay/src/vaadin-overlay-mixin.js b/packages/overlay/src/vaadin-overlay-mixin.js
@@ -156,6 +156,11 @@ export const OverlayMixin = (superClass) =>
     disconnectedCallback() {
       super.disconnectedCallback();
 
+      if (this.__scheduledOpen) {
+        cancelAnimationFrame(this.__scheduledOpen);
+        this.__scheduledOpen = null;
+      }
+
       /* c8 ignore next 3 */
       if (this._boundIosResizeListener) {
         window.removeEventListener('resize', this._boundIosResizeListener);
diff --git a/packages/overlay/test/basic.test.js b/packages/overlay/test/basic.test.js
@@ -44,6 +44,16 @@ describe('vaadin-overlay', () => {
       expect(spy).to.not.be.called;
     });
 
+    it('should not fire when immediately disconnected after setting opened to true', async () => {
+      overlay.opened = true;
+      overlay.remove();
+
+      await nextFrame();
+      await aTimeout(0);
+
+      expect(spy).to.not.be.called;
+    });
+
     it('should not propagate through shadow roots', async () => {
       overlay.opened = true;
       await nextFrame();
