Reviewing files that changed from the base of the PR and between 32a0f7c and 83cac2c.

• README.md (2 hunks)
• holidays/calendars/__init__.py (1 hunks)
• holidays/calendars/mongolian.py (1 hunks)
• holidays/countries/__init__.py (1 hunks)
• holidays/countries/mongolia.py (1 hunks)
• holidays/groups/__init__.py (1 hunks)
• holidays/groups/eastern.py (1 hunks)
• holidays/groups/mongolian.py (1 hunks)
• holidays/locale/en_MN/LC_MESSAGES/MN.po (1 hunks)
• holidays/locale/en_US/LC_MESSAGES/MN.po (1 hunks)
• holidays/locale/mn/LC_MESSAGES/MN.po (1 hunks)
• holidays/registry.py (1 hunks)
• scripts/calendar/asian_generator.py (4 hunks)
• tests/countries/test_mongolia.py (1 hunks)

holidays/groups/__init__.py (1)

25-25: Mongolian group import added correctly. The MongolianCalendarHolidays class is now exposed in the groups namespace, matching the new module.

holidays/countries/__init__.py (1)

127-127: Mongolia provider import integrated properly. The Mongolia, MN, MNG import is in alphabetical order between Monaco and Montenegro, aligning with project conventions.

holidays/groups/eastern.py (1)

31-35: Docstring update includes Mongolian calendar. The description now correctly lists Mongolian alongside Buddhist, Chinese, Hindu, and Islamic calendars.

holidays/calendars/__init__.py (1)

25-25: Imported Mongolian calendar classes. The _CustomMongolianHolidays and _MongolianLunisolar are now available in the calendars namespace.

README.md (1)

108-108: Supported countries count updated. The total was incremented to 184 to reflect Mongolia's addition. Ensure this matches the actual supported list.

holidays/locale/en_MN/LC_MESSAGES/MN.po (1)

1-56: Localization file structure looks good.

The PO file follows proper format with appropriate metadata headers and holiday entries. The empty msgstr fields are expected for the en_MN locale.

holidays/locale/en_US/LC_MESSAGES/MN.po (1)

1-56: English localization looks comprehensive.

The en_US locale file properly provides English translations for all Mongolian holidays. Translations are accurate and follow standard naming conventions.

holidays/locale/mn/LC_MESSAGES/MN.po (1)

1-57: Mongolian translations look well-formatted.

The native Mongolian locale file is properly structured with Cyrillic script translations. The formatting and encoding appear correct, though translation accuracy should ideally be verified by a native Mongolian speaker.

holidays/countries/mongolia.py (1)

1-76: Excellent implementation following established patterns.

The Mongolia holiday provider is well-structured with proper inheritance, metadata, and holiday definitions. The conditional logic for Republic Day starting in 1925 correctly reflects historical context. Class aliases follow standard conventions.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 1-1: Missing module docstring

(C0114)

---

[convention] 70-70: Missing class docstring

(C0115)

---

[convention] 74-74: Missing class docstring

(C0115)

tests/countries/test_mongolia.py (3)

19-26: Perfect test class structure following established patterns.

The class correctly inherits from CommonCountryTests and TestCase, and the setUpClass method properly sets up the test range from 1912-2049 matching the Mongolia provider's start year.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 19-19: Missing class docstring

(C0115)

---

[warning] 21-21: Number of parameters was 4 in 'TestCase.setUpClass' and is now 1 in overriding 'TestMongolia.setUpClass' method

(W0221)

---

[convention] 25-25: Missing function or method docstring

(C0116)

---

48-61: Comprehensive year-specific test validates all holidays.

The 2025 test thoroughly validates all expected holidays including the multi-day Naadam festival (July 11-15), ensuring correct date-to-name mappings.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 48-48: Missing function or method docstring

(C0116)

---

63-105: Excellent localization test coverage.

Tests validate holiday names in default (en_MN), Mongolian (mn), and US English (en_US) locales, ensuring proper internationalization support.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 63-63: Missing function or method docstring

(C0116)

---

[convention] 77-77: Missing function or method docstring

(C0116)

---

[convention] 92-92: Missing function or method docstring

(C0116)

holidays/calendars/mongolian.py (2)

25-215: Comprehensive date data for Mongolian lunisolar calendar.

The extensive dictionary covering 1912-2100 provides solid foundation for Tsagaan Sar calculations. Data appears consistent with lunisolar calendar patterns.

---

230-231: Clean API method for Tsagaan Sar date retrieval.

The method provides a clear interface for getting Tsagaan Sar dates with estimation flags.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 230-230: Missing function or method docstring

(C0116)

holidays/groups/mongolian.py (2)

21-28: Well-designed mixin class for Mongolian calendar holidays.

The class properly extends EasternCalendarHolidays and initializes the Mongolian calendar with configurable estimation display.

🧰 Tools

🪛 Pylint (3.3.7)

[refactor] 21-21: Too few public methods (0/2)

(R0903)

---

62-96:

✅ Verification successful

Verify _year attribute availability in inheritance chain.

The methods reference self._year which isn't defined in this class. Ensure this class is properly mixed with a class that provides the _year attribute.

Run this script to verify the inheritance pattern:

---

🏁 Script executed:

#!/bin/bash
# Description: Verify that MongolianCalendarHolidays is used with classes that provide _year

# Search for classes that inherit from MongolianCalendarHolidays
ast-grep --pattern 'class $_ ($$$, MongolianCalendarHolidays$$$) {
  $$$
}'

# Search for _year attribute in base classes
rg -A 5 "_year.*=" holidays/holiday_base.py holidays/groups/

Length of output: 13926

---

I want to double-check how MongolianCalendarHolidays is defined and where it’s mixed into a concrete country class. Let’s inspect the class declaration in holidays/groups/mongolian.py:

---

🏁 Script executed:

#!/bin/bash
# List class definitions in the Mongolian mixin and show its beginning
rg --color=never -n "class " holidays/groups/mongolian.py
sed -n '1,200p' holidays/groups/mongolian.py

Length of output: 3918

---

Let’s inspect the country class that pulls in MongolianCalendarHolidays to see how its __init__ chain is wired:

#!/bin/bash
# 1. Find the file(s) defining the Mongolia country class
country_files=$(rg -l "class Mongolia" -g "*.py")

echo "Mongolia country class found in:"
echo "$country_files"

# 2. Show the class declaration and any __init__ override
for f in $country_files; do
  echo -e "\n--- $f: class declaration ---"
  rg -A10 -n "class Mongolia" "$f"
  echo -e "\n--- $f: __init__ method ---"
  rg -A5 -n "def __init__" "$f" || echo "No __init__ in $f"
done

---

Let’s locate and inspect the Mongolia country class to see how its __init__ wires in both HolidayBase and MongolianCalendarHolidays:

---

🏁 Script executed:

#!/bin/bash
# 1. Find files defining class Mongolia
files=$(rg -l "class Mongolia" -g "*.py")
echo "Found in: $files"

# 2. Show the class declaration and __init__ for each
for f in $files; do
  echo -e "\n--- $f: class & __init__ ---"
  rg -A5 -n "class Mongolia" "$f"
  rg -A10 -n "def __init__" "$f" || echo "No __init__ in $f"
done

Length of output: 2150

---

Verified: _year is provided by HolidayBase via super().__init__

The Mongolia country class calls InternationalHolidays.__init__ and then super().__init__(*args, **kwargs), which invokes HolidayBase.__init__ (setting self._year). The mix-in chain guarantees _year is available—no changes needed.

🧰 Tools

🪛 Pylint (3.3.7)

[error] 71-71: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

---

[error] 83-83: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

---

[error] 95-95: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

scripts/calendar/asian_generator.py (5)

300-307: Clean implementation following established patterns.

The method correctly calculates Buddha Day using the 15th day of the 4th lunar month, consistent with other lunisolar date methods in the class.

---

370-376: Proper integration of Mongolian calendar support.

The enumeration and dictionary updates correctly follow the established pattern for adding new calendar types.

---

380-380: Correct timezone classification.

Adding Mongolia (MN) to the UTC+8 list is factually accurate.

---

383-410: Holiday entries follow correct format.

The new Mongolian holiday entries properly follow the established tuple pattern and use the correct calendar enumeration.

---

318-325:

❓ Verification inconclusive

Fix inconsistency between comment and implementation.

The comment states "1st day of the 6th month" but the code uses lunar_to_gre(year, 10, 1) (10th month). This mismatch needs clarification.

---

🏁 Script executed:

#!/bin/bash
# Verify the correct lunar month for Genghis Khan's Birthday
rg -A 10 -B 5 "Genghis Khan" --type md

Length of output: 40

---

Let’s broaden our search for any mentions of Genghis Khan’s birthday in the repo to pin down the correct lunar month:

---

🏁 Script executed:

#!/bin/bash
# Search repository for any references to Genghis Khan’s birthday
rg -i "genghis khan" -C5

Length of output: 1661

---

Clarify Mongolian lunar month for Genghis Khan’s Birthday
The docstring says “1st day of the 6th month” but both the implementation (lunar_to_gre(year, 10, 1)) and the holiday tuple (10, 1, "GENGHIS_KHAN_DAY", MONGOLIAN) use the 10th month. Please confirm the correct lunar month and then either:

• Update the docstring to “1st day of the 10th month of the Mongolian lunar calendar.”
• Or adjust the code/tuple to use the 6th month if that’s the accurate date.

Files to review:

• scripts/calendar/asian_generator.py → genghis_khan_day_date docstring (lines 318–325)
• scripts/calendar/asian_generator.py → holiday definition tuple

Reviewing files that changed from the base of the PR and between 32f89be and c7dfad9.

• README.md (2 hunks)
• holidays/countries/mongolia.py (1 hunks)
• holidays/locale/en_MN/LC_MESSAGES/MN.po (1 hunks)
• holidays/locale/en_US/LC_MESSAGES/MN.po (1 hunks)
• holidays/locale/mn/LC_MESSAGES/MN.po (1 hunks)
• tests/countries/test_mongolia.py (1 hunks)

README.md (1)

941-946: LGTM - Mongolia entry properly structured.

The table entry follows the correct format with appropriate country code, language support, and alphabetical positioning.

holidays/locale/en_US/LC_MESSAGES/MN.po (1)

1-60: Well-structured localization file.

The PO file follows proper gettext format with appropriate metadata and clean English translations for Mongolian holidays.

holidays/locale/en_MN/LC_MESSAGES/MN.po (1)

1-60: Consistent English localization for en_MN locale.

The file properly supports the en_MN locale with appropriate English translations. Content consistency with en_US version appears intentional.

holidays/locale/mn/LC_MESSAGES/MN.po (1)

30-61: Appropriate native language handling.

The empty msgstrs ensure Mongolian holiday names display in their native form, which is the correct approach for preserving cultural authenticity.

holidays/countries/mongolia.py (2)

19-37: Solid holiday provider implementation.

The class structure properly inherits from the required base classes and sets appropriate metadata. The start year and language configuration align with the discussion in past reviews.

---

38-73: Well-implemented holiday logic.

The holiday definitions follow proper patterns with conditional logic for historical changes. The use of translatable strings and appropriate date methods looks correct.

tests/countries/test_mongolia.py (7)

1-17: Well-structured imports and setup following established patterns.

The file follows the proper structure with correct imports and matches the pattern from other country test files. The copyright header is standard and imports are appropriate.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 1-1: Missing module docstring

(C0114)

---

19-23: Proper test class setup with correct inheritance.

Good use of the CommonCountryTests pattern and appropriate year range (2004-2050). The setUpClass method correctly calls the parent class setup.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 19-19: Missing class docstring

(C0115)

---

[warning] 21-21: Number of parameters was 4 in 'TestCase.setUpClass' and is now 1 in overriding 'TestMongolia.setUpClass' method

(W0221)

---

25-29: Solid country aliases and boundary testing.

Both methods correctly test the country aliases and verify no holidays exist before 2004, establishing proper boundaries for the holiday data.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 25-25: Missing function or method docstring

(C0116)

---

[convention] 28-28: Missing function or method docstring

(C0116)

---

31-46: Comprehensive coverage of core holidays.

The tests for New Year, Women's Day, Children's Day, and Republic Day are well-structured with proper Mongolian holiday names and consistent date ranges.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 31-31: Missing function or method docstring

(C0116)

---

[convention] 34-34: Missing function or method docstring

(C0116)

---

[convention] 39-39: Missing function or method docstring

(C0116)

---

[convention] 42-42: Missing function or method docstring

(C0116)

---

47-56: Excellent handling of holiday name evolution over time.

This test properly captures the evolution of Independence Day naming across different periods (2007-2010 vs 2011+), demonstrating thoughtful attention to historical accuracy.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 47-47: Missing function or method docstring

(C0116)

---

58-71: Comprehensive year-specific test with multi-day festival coverage.

The 2025 test provides excellent validation of all holidays including the multi-day Naadam festival. This gives confidence in the complete holiday implementation.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 58-58: Missing function or method docstring

(C0116)

---

73-115: Thorough localization testing across multiple locales.

The localization tests properly cover default (Mongolian), en_MN, and en_US variants, ensuring proper translation support. This demonstrates solid internationalization coverage.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 73-73: Missing function or method docstring

(C0116)

---

[convention] 87-87: Missing function or method docstring

(C0116)

---

[convention] 102-102: Missing function or method docstring

(C0116)

Reviewing files that changed from the base of the PR and between c97eac5 and 4cf5bd3.

• README.md (2 hunks)
• scripts/calendar/mongolian_generator.py (1 hunks)

scripts/calendar/mongolian_generator.py (1)

47-49: Update constant references after renaming.

Remember to update the constant references here.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 47-47: Missing function or method docstring

(C0116)

README.md (1)

941-946:

✅ Verification successful

Verify default language designation.

The entry correctly adds Mongolia with mn as the default language (in bold), which aligns with the past review comment suggesting this.

Let me verify Mongolia's language configuration matches what's defined in the codebase:

---

🏁 Script executed:

#!/bin/bash
# Check Mongolia's language configuration in the code
echo "Checking Mongolia's default language configuration..."
rg -A 5 "class Mongolia" holidays/countries/
echo -e "\nChecking for default_language attribute..."
ast-grep --pattern 'default_language = $_'

Length of output: 9490

---

Default language for Mongolia verified

The default_language in holidays/countries/mongolia.py:30 is set to "mn", which matches the README’s bolded entry. All good to merge.

Reviewing files that changed from the base of the PR and between e45d702 and eb4df44.

• README.md (2 hunks)

README.md (1)

941-946: Mongolia table row is well-formed.

The new Mongolia entry is correctly inserted, the HTML table syntax is valid, and the default language (mn) is bolded as intended.

Reviewing files that changed from the base of the PR and between eb4df44 and 4f9685b.

• holidays/calendars/mongolian.py (1 hunks)
• holidays/groups/mongolian.py (1 hunks)
• scripts/calendar/mongolian_generator.py (1 hunks)

holidays/calendars/mongolian.py (4)

19-21: Good choice using descriptive constants for holiday names.

The constant definitions provide clear, reusable identifiers that improve maintainability across the codebase.

---

25-323: Comprehensive holiday date mappings.

The extensive date dictionaries covering 2004-2100 provide solid long-term support for Mongolian holidays. Data appears well-structured and follows consistent formatting.

---

325-329: Robust holiday date retrieval logic.

The method correctly handles both exact and estimated dates with proper fallback logic. The tuple return format with estimation flag is well-designed for downstream usage.

---

341-342: Clean integration design.

The _CustomMongolianHolidays class provides clean integration between custom calendar functionality and Mongolian lunisolar calculations through multiple inheritance.

holidays/groups/mongolian.py (5)

20-28: Well-structured calendar holidays class.

The class design properly extends EasternCalendarHolidays and initializes calendar dependencies cleanly. The optional custom calendar class parameter provides good flexibility.

🧰 Tools

🪛 Pylint (3.3.7)

[refactor] 20-20: Too few public methods (0/2)

(R0903)

---

29-41: Solid delegation pattern for holiday addition.

The _add_mongolian_calendar_holiday method provides clean delegation to the eastern calendar framework while maintaining Mongolian-specific behavior.

---

43-53: Excellent documentation with historical context.

The method documentation includes valuable context about Tsagaan Sar with proper Wikipedia references. Implementation correctly uses the calendar's date calculation.

🧰 Tools

🪛 Pylint (3.3.7)

[error] 52-52: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

---

55-77: Consistent pattern for multi-day holidays.

The Tsagaan Sar day 2 and day 3 methods follow a clean pattern using days_delta parameter. Documentation maintains consistency across related methods.

🧰 Tools

🪛 Pylint (3.3.7)

[error] 64-64: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

---

[error] 76-76: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

---

79-103: Comprehensive holiday implementations.

Both Buddha Day and Genghis Khan Day methods include proper documentation with historical context and correct calendar integration. The implementation pattern is consistent across all holiday methods.

🧰 Tools

🪛 Pylint (3.3.7)

[error] 89-89: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

---

[error] 102-102: Instance of 'MongolianCalendarHolidays' has no '_year' member

(E1101)

scripts/calendar/mongolian_generator.py (2)

160-188: Solid date generation and file output logic.

The main generation function correctly iterates through years, formats dates properly, and handles file I/O cleanly. The template-based approach for generating the output class is well-designed.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 160-160: Missing function or method docstring

(C0116)

---

[warning] 171-171: Catching too general exception Exception

(W0718)

---

153-157: Clean holiday configuration setup.

The MONGOLIAN_HOLIDAYS list provides a clean mapping between holiday names and calculation functions. The lambda expressions for festival dates are concise and appropriate.