Skip to content

Add dqn_atari.py documentation #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 24, 2022
Merged

Add dqn_atari.py documentation #124

merged 14 commits into from
Mar 24, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Feb 27, 2022 •
edited
Loading

Checklist for dqn_atari.py:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have contacted @vwxyzjn to obtain access to the openrlbenchmark W&B team (required).
  • I have tracked applicable experiments in openrlbenchmark/cleanrl with --capture-video flag toggled on (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.
    • I have explained note-worthy implementation details.
    • I have explained the logged metrics.
    • I have added links to the original paper and related papers (if applicable).
    • I have added links to the PR related to the algorithm.
    • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves (in PNG format with width=500 and height=300).
    • I have added links to the tracked experiments.
  • I have updated the tests accordingly (if applicable).

@gitpod-io
Copy link

gitpod-io bot commented Feb 27, 2022

@vercel
Copy link

vercel bot commented Feb 27, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/5XzX8iLxDYW7VV9A6Y85BrGaFnxq
✅ Preview: https://cleanrl-git-dqnpy-docs-vwxyzjn.vercel.app

@vwxyzjn vwxyzjn changed the title Add dqn.py documentation Add dqn.py documentation Feb 27, 2022
@vwxyzjn vwxyzjn mentioned this pull request Feb 27, 2022
Closed
10 tasks
@vwxyzjn vwxyzjn changed the title Add dqn.py documentation Add dqn.py and dqn_atari.py documentation Feb 28, 2022
@vwxyzjn vwxyzjn changed the title Add dqn.py and dqn_atari.py documentation Add dqn_atari.py documentation Mar 23, 2022
@vwxyzjn vwxyzjn requested review from dosssman and yooceii March 23, 2022 14:11
@vwxyzjn vwxyzjn merged commit 6febe20 into master Mar 24, 2022
@vwxyzjn vwxyzjn mentioned this pull request Apr 20, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yooceii yooceii yooceii approved these changes

@dosssman dosssman dosssman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vwxyzjn @yooceii @dosssman