USWDS-Site: Add changelog for modal PREFIX constants [#6026] #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add focus trap guidance.
Add changelog entry to Modal focus trap guidance.
Replacing this: Test print outputs. Test printing using a variety of printers, print-to-PDF options, and assistive output devices, using representative browser and operating system combinations prior to launch. Remember that mobile device users will have additional challenges printing or saving to PDF so some on-screen guidance may be necessary. with this: Test print outputs. Test printing using a variety of printers, print-to-PDF options, and assistive output devices, using representative browser and operating system combinations based on your site's visitor data prior to launch. Remember that mobile device users will have additional challenges printing or saving to PDF so some on-screen guidance may be necessary.
Will need updated date when ready to publish
This was referenced Nov 5, 2024
update changelog date
amyleadem
reviewed
Nov 5, 2024
…eprecord_update
Updating content and link in Test broadly section
USWDS-Site - Modal: Update accessibility guidance
USWDS-site: Replace nunjucks reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a changelog entry for changes to the Modal component JavaScript. Because the component takes advantage of constants, users can bundle the modal package with a custom prefix.
Related issue
[USWDS - Modal: Use classname constants for all variable references in JS file]
Preview link
USWDS-Site: Modal
Testing and review