-
Notifications
You must be signed in to change notification settings - Fork 195
USWDS-Site - Documentation: Add $theme-utility-breakpoints-custom
to settings table.
#2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mahoneycm Should the base branch on this bb be |
…ustom-breakpoint-documentation
@@ -2,6 +2,14 @@ title: Settings | |||
type: utility | |||
changelogURL: | |||
items: | |||
- date: NNNN-NN-NN | |||
summary: Added new `$theme-utility-breakpoints-custom` setting. | |||
summaryAdditional: Users can now set custom breakpoints which will generate utilities alongside the default system breakpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Some minor tweaks to improve readability
summaryAdditional: Users can now set custom breakpoints which will generate utilities alongside the default system breakpoints. | |
summaryAdditional: This setting generates responsive variants of USWDS utilities at custom breakpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amyleadem I'd argue that the original is a little clearer. First, it mentions that this is a new setting and second it tells you that new utils can be generated from it.
suggestion:
|
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog looks good and added suggestion for clarity in settings table.
Update: I'm going to move my suggestions to enhance responsive-variants.html to a separate PR so that it doesn't hold up the release. We can evaluate it independently as a follow-on if needed Update to the update: I opened #2852 for this proposed addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this with the acknowledgment that we might follow up with future information in #2852.
Summary
Added
$theme-utility-breakpoints-custom
setting to the utility settings table.$theme-utility-breakpoints-custom
Related PR
Documentation for uswds/uswds#6048
Preview link
Settings page →
Major changes
Testing and review